-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link in dashboard with broken objects #4224
Conversation
This LGTM. There seems to be a lot of custom code in a number of places when using the Also, if we used an IndexedArray in there, you could get rid of your type mapping stuff and just use |
Yeah, |
Everything here looks good, except that the 'notFound' query string param accepted by the saved object editor is not being utilized. This param displays a message helping the user understand what's going on. The simplest solution was pretty dirty so I played around and wrote a solution that I think is a little cleaner. @lukasolson sent you a pr lukasolson#5 |
display info about missing object
LGTM! |
Fix broken link in dashboard with broken objects
Closes #4200.
When you have an object inside a dashboard that links to a no-longer-existent index pattern (or is in some way otherwise broken), the edit link was bad and would send you to a 404 page.
With this change, we link to the object editor in such cases, so you can modify the object. If the object itself has been deleted, the edit link should no longer show up at all.
This PR also removes the Inflection library, because it was only used in one place (to singularize "searches" to "search" etc.) and it wasn't even necessary.