[Uptime] Handle mode: all in uptime snapshot calculation
#41335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
added
bug
|
Pinging @elastic/uptime |
andrewvc
added
the
release_note:skip
Patching this function in elastic#41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present.
andrewvc
force-pushed
the
fix-snapshot-mode-all
branch
from
d90596e
to
6b638dd
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
justinkambic
approved these changes
Jul 17, 2019
|
|
||
| const fixturesDir = join(__dirname, 'fixtures'); | ||
|
|
||
| export const expectFixtureEql = (data: any, fixtureName: string) => { |
There was a problem hiding this comment.
Great! This is along the lines of the solution I was planning to use to address this.
|
FYI I created merge conflicts for your branch by merging updates to the README. Took the liberty of merging the changes. |
💔 Build Failed |
|
jenkins, retest this please |
💚 Build Succeeded |
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Jul 18, 2019
…1335) Patching this function in elastic#41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present.
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Jul 18, 2019
…1335) Patching this function in elastic#41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present.
andrewvc
added a commit
that referenced
this pull request
Jul 18, 2019
) (#41424) * [Uptime] Handle `mode: all` in uptime snapshot calculation (#41335) Patching this function in #41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present. * Update snapshot to use heartbeat7.0.0 index for backport
andrewvc
added a commit
that referenced
this pull request
Jul 18, 2019
) (#41423) * [Uptime] Handle `mode: all` in uptime snapshot calculation (#41335) Patching this function in #41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present. * Update snapshot to use heartbeat7.0.0 index for backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching this function in #41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present.
This needs additional tests before merging.Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers