Fix/re enable skipped functional tests #41238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
force-pushed
the
fix/re-enable-skipped-functional-tests
branch
from
7c4e822
to
97d0718
Compare
💔 Build Failed |
💔 Build Failedknown flaky one: |
dmlemeshko
force-pushed
the
fix/re-enable-skipped-functional-tests
branch
from
97d0718
to
9982eaf
Compare
💚 Build Succeeded |
💔 Build Failed |
|
retest |
💚 Build SucceededRe-running jobs that contain new tests 10x times. |
|
retest |
💚 Build SucceededRe-running jobs that contain new tests 10x times. |
This reverts commit ad7302f.
…pped-functional-tests
dmlemeshko
added
test_ui_functional
test_xpack_functional
release_note:skip
💔 Build FailedUnrelated tests failed, guess they should be skipped in master. |
chrisronline
approved these changes
Jul 17, 2019
…pped-functional-tests
💚 Build Succeeded |
LeeDr
approved these changes
Jul 17, 2019
I checked it and there is no |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 18, 2019
* [home/_sample_data] unskip tests * [visualize/_tsvb_chart] unskip switch index pattern test * unskip nodes filter test * run specific groups 10x times * Revert "run specific groups 10x times" This reverts commit ad7302f.
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 18, 2019
* [home/_sample_data] unskip tests * [visualize/_tsvb_chart] unskip switch index pattern test * unskip nodes filter test * run specific groups 10x times * Revert "run specific groups 10x times" This reverts commit ad7302f.
dmlemeshko
added a commit
that referenced
this pull request
Jul 18, 2019
dmlemeshko
added a commit
that referenced
this pull request
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found that some functional tests were skipped without comment or commented issue is closed now.
This PR brings these tests back to run.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately