Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Add explicit alignments to table columns #40680

Merged
merged 9 commits into from
Jul 17, 2019

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves #40583.

It has been noted that we have inconsistent alignments in the table columns of Uptime's UI. This patch is intended to rectify the situation.

Testing this PR

  1. Start up Heartbeat, ES, and this branch. Navigate to Uptime.
  2. From the UI, make certain that all the text columns are left-aligned and the number columns are right-aligned.

@justinkambic justinkambic added release_note:fix v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.3.0 v7.4.0 labels Jul 9, 2019
@justinkambic justinkambic self-assigned this Jul 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@katrin-freihofner katrin-freihofner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. 🦝

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic justinkambic merged commit 2a8cbff into elastic:master Jul 17, 2019
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jul 17, 2019
* Add explicit alignments to table columns.

* Fix broken prop and snapshots.

* Fix pagination item count and update snapshot to match changes.
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jul 17, 2019
* Add explicit alignments to table columns.

* Fix broken prop and snapshots.

* Fix pagination item count and update snapshot to match changes.
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jul 18, 2019
* Add explicit alignments to table columns.

* Fix broken prop and snapshots.

* Fix pagination item count and update snapshot to match changes.
justinkambic added a commit that referenced this pull request Jul 18, 2019
* Add explicit alignments to table columns.

* Fix broken prop and snapshots.

* Fix pagination item count and update snapshot to match changes.
justinkambic added a commit that referenced this pull request Jul 18, 2019
* Add explicit alignments to table columns.

* Fix broken prop and snapshots.

* Fix pagination item count and update snapshot to match changes.
@justinkambic
Copy link
Contributor Author

@justinkambic justinkambic deleted the uptime_column-alignment branch July 18, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.3.0 v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime Ui] improve alignment of text in columns
3 participants