Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Fix inaccuracy when jumping to a faraway time target #40303

Merged
merged 3 commits into from
Jul 9, 2019
+9 −2
Merged

[Logs UI] Fix inaccuracy when jumping to a faraway time target #40303

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3fe74c
[Logs UI] Fix inaccuracy when jumping to a faraway time target
Zacqary Jul 3, 2019
65ea956
Merge branch 'master' of github.com:elastic/kibana into 39944-log-jum…
Zacqary Jul 3, 2019
dd5bca3
Merge branch 'master' of github.com:elastic/kibana into 39944-log-jum…
Zacqary Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .../legacy/plugins/infra/public/components/logging/log_text_stream/vertical_scroll_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,19 @@ export class VerticalScrollPanel<Child> extends React.PureComponent<
public getSnapshotBeforeUpdate(
prevProps: VerticalScrollPanelProps<Child>
): VerticalScrollPanelSnapshot<Child> {
if (prevProps.target !== this.props.target && this.props.target) {
/** Center the target if:
* 1. This component has just finished calculating its height after being first mounted
* 2. The target prop changes
*/
if (
(prevProps.height === 0 && this.props.height > 0) ||
(prevProps.target !== this.props.target && this.props.target)
) {
return {
scrollOffset: undefined,
scrollTarget: this.props.target,
};
} else {
} else if (this.props.height > 0) {
const visibleChildren = this.getVisibleChildren();

if (visibleChildren) {
Expand Down