component integration tests for watch status page

[alisonelizabeth]

This PR adds component integration tests for the watch status page in watcher. All routes should have test coverage now.

[elasticmachine]

Pinging @elastic/es-ui

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[cuff-links]

Be sure to set React and ReactDOM to 16.9.0-alpha.0 or these tests will not work.

[cuff-links]

I really like the tests and the coverage provided. I ran through these manually while going through the code to see what scenarios are covered. I would suggest covering the editing a watch action. Just make sure that changing some info persists in the UI and updates the table. Something like that. Be glad to approve thereafter.

[cjcenizal]

These tests are failing on CI with errors that look like this:

09:25:20     Configuration error:
09:25:20     
09:25:20     Could not locate module plugins/watcher/models/settings mapped as:
09:25:20     /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-intake/node/immutable/kibana/src/legacy/core_plugins/watcher/public/models/settings.
09:25:20     
09:25:20     Please check your configuration for these entries:
09:25:20     {
09:25:20       "moduleNameMapper": {
09:25:20         "/^plugins\/([^\/.]*)(.*)/": "/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-intake/node/immutable/kibana/src/legacy/core_plugins/$1/public$2"
09:25:20       },
09:25:20       "resolver": null
09:25:20     }
09:25:20 
09:25:20        6 | import { Settings } from 'plugins/watcher/models/settings';
09:25:20        7 | import { Watch } from 'plugins/watcher/models/watch';
09:25:20     >  8 | import { WatchHistoryItem } from 'plugins/watcher/models/watch_history_item';
09:25:20          |                 ^
09:25:20        9 | import { WatchStatus } from 'plugins/watcher/models/watch_status';
09:25:20       10 | 
09:25:20       11 | import { __await } from 'tslib';
09:25:20 
09:25:20       at createNoMappedModuleFoundError (../node_modules/jest-resolve/build/index.js:436:17)
09:25:20       at Object.<anonymous> (legacy/plugins/watcher/public/lib/api.ts:8:17)

[alisonelizabeth]

@silne30 thanks for the review!

This PR is specifically for the watch status page (where you can view the execution history and actions). I previously created a test file for editing a watch. See: https://github.com/elastic/kibana/blob/watcher-port/x-pack/legacy/plugins/watcher/__jest__/client_integration/watch_edit.test.ts

Do you think that is sufficient, or do you think there are other scenarios we should add?

[alisonelizabeth]

@cjcenizal that should be fixed now! there was a change in master that caused the failure.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[cuff-links]

OK. That makes sense. Since the Component Integration Tests are more about the components and less about E2E, I will make sure to add an issue to add a smoke level functional test for the between page interaction. We're good.

[alisonelizabeth]

retest

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request