Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create common watch actions component #36056

Merged
merged 2 commits into from
May 6, 2019
Merged

create common watch actions component #36056

merged 2 commits into from
May 6, 2019

Conversation

alisonelizabeth
Copy link
Contributor

This PR addresses the following:

  • Created a common action status component that can be reused across watch list, watch details and advanced watch pages.
  • Moved the status icon on the Simulation results flyout underneath the title
  • Created an index.ts file for common components

Screenshots

Possible states:
Screen Shot 2019-05-03 at 4 09 43 PM

Simulation results flyout:
Screen Shot 2019-05-03 at 4 10 05 PM

@alisonelizabeth alisonelizabeth added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Watcher non-issue Indicates to automation that a pull request should not appear in the release notes labels May 3, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cjcenizal
cjcenizal approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Code LGTM, didn't test locally.

x-pack/plugins/watcher/public/components/watch_status.tsx Outdated
case ACTION_STATES.THROTTLED:
return <EuiIcon type="clock" color="warning" />;
case WATCH_STATES.DISABLED:
return <EuiIcon type="minusInCircleFilled" color="#69707D" />; // EUI color: euiColorDarkShade
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was "subdued" too hard to see? If "subdued" doesn't work, then could you submit an issue in the EUI repo asking for this to be supported via a color name like "disabled" or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subdued works, thanks! i didn't see that as an option initially.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alisonelizabeth alisonelizabeth merged commit 4162b6b into elastic:watcher-port May 6, 2019
@alisonelizabeth alisonelizabeth deleted the watch-action-states branch May 6, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
Feature:Watcher non-issue Indicates to automation that a pull request should not appear in the release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alisonelizabeth @elasticmachine @cjcenizal