Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Central configuration management #36031

Closed
wants to merge 3 commits into from
Closed

[APM] Central configuration management #36031

wants to merge 3 commits into from

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented May 3, 2019 •
edited
Loading

TODO:

  • Create index template for CM index
  • Update documentation with cmIndex settings

Questions:

  • Should the index template for the CM index be created by Kibana or APM Server? (APM Server)
  • Should the API return a list of configs or just a single? (Single config)
  • If no config is found, should the API return 404 (not found), 204 (empty) or 200 (success)?
  • Should it be possible to create a config, if another config already exists for the exact same combination of service.name and service.environment? (No)

Closes #34990

@sorenlouv sorenlouv requested a review from a team as a code owner May 3, 2019 14:24
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sorenlouv sorenlouv force-pushed the central-config-management branch 2 times, most recently from ed79397 to cdf3567 Compare May 23, 2019 12:06
@elasticmachine
Copy link
Contributor

💔 Build Failed

This was referenced May 23, 2019
Closed
Closed
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sorenlouv
[APM] Central configuration management
45c8989 
List configs

wip

wip2

wip3
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jalvz
Copy link
Contributor

jalvz commented Jun 17, 2019

server support landed: elastic/apm-server#2289

@elasticmachine
Copy link
Contributor

💔 Build Failed

@formgeist formgeist mentioned this pull request Jun 19, 2019
Closed
@ogupte ogupte mentioned this pull request Jun 25, 2019
Merged
@ogupte ogupte closed this Jun 25, 2019
@ogupte
Copy link
Contributor

ogupte commented Jun 25, 2019

Continue discussion at #39555

@sorenlouv sorenlouv deleted the central-config-management branch July 18, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Central Configuration Management for agents in APM UI
5 participants
@sorenlouv @elasticmachine @jalvz @ogupte @formgeist