-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][skip ci] Read only access for @elastic/kibana-app applications #35560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
changed the title
Docs - Readonly Badges for @elastic/kibana-app applications
[docs][skip ci] Read only badges for @elastic/kibana-app applications
Apr 24, 2019
kobelb
changed the title
[docs][skip ci] Read only badges for @elastic/kibana-app applications
[docs][skip ci] Read only access for @elastic/kibana-app applications
Apr 24, 2019
lizozom
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments
But generally LGTM
Hey @lizozom, I'm not seeing any other comments, perhaps Github swallowed them? |
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jun 6, 2019
…elastic#35560) * Adding read-only mode section to Discover * No more "mode" or "badge" terminology * Putting newline back * Adding "Saving" section for visualize * Adding dashboard read only access section * Timelion gets read-only documentation * Adding read only access section to index patterns and advanced settings * Adding graph read only access section
This was referenced Jun 6, 2019
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jun 6, 2019
…elastic#35560) * Adding read-only mode section to Discover * No more "mode" or "badge" terminology * Putting newline back * Adding "Saving" section for visualize * Adding dashboard read only access section * Timelion gets read-only documentation * Adding read only access section to index patterns and advanced settings * Adding graph read only access section
@kobelb forgot to submit my review. Looks good! |
kobelb
added a commit
that referenced
this pull request
Jun 13, 2019
…#35560) (#38306) * Adding read-only mode section to Discover * No more "mode" or "badge" terminology * Putting newline back * Adding "Saving" section for visualize * Adding dashboard read only access section * Timelion gets read-only documentation * Adding read only access section to index patterns and advanced settings * Adding graph read only access section
kobelb
added a commit
that referenced
this pull request
Jun 13, 2019
…#35560) (#38307) * Adding read-only mode section to Discover * No more "mode" or "badge" terminology * Putting newline back * Adding "Saving" section for visualize * Adding dashboard read only access section * Timelion gets read-only documentation * Adding read only access section to index patterns and advanced settings * Adding graph read only access section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of "read only mode" to all of the applications, we're displaying an indicator in the header to prompt users that they won't be able to save the various saved objects. This PR updates the documentation to also mention read-only mode and the various operations which the user won't be able to perform.
This updates the documentation for: Discover, Dashboards, Visualize, Graph, Advanced Settings, Index Patterns and Timelion