Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][skip ci] Read only access for @elastic/kibana-app applications #35560

Merged
merged 9 commits into from
Jun 6, 2019

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Apr 24, 2019

With the addition of "read only mode" to all of the applications, we're displaying an indicator in the header to prompt users that they won't be able to save the various saved objects. This PR updates the documentation to also mention read-only mode and the various operations which the user won't be able to perform.

This updates the documentation for: Discover, Dashboards, Visualize, Graph, Advanced Settings, Index Patterns and Timelion

@kobelb kobelb changed the title Docs - Readonly Badges for @elastic/kibana-app applications [docs][skip ci] Read only badges for @elastic/kibana-app applications Apr 24, 2019
@kobelb kobelb changed the title [docs][skip ci] Read only badges for @elastic/kibana-app applications [docs][skip ci] Read only access for @elastic/kibana-app applications Apr 24, 2019
@elastic elastic deleted a comment from elasticmachine Apr 24, 2019
@kobelb kobelb marked this pull request as ready for review May 24, 2019 16:48
@kobelb kobelb requested a review from a team May 30, 2019 18:54
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments
But generally LGTM

@kobelb
Copy link
Contributor Author

kobelb commented Jun 3, 2019

Added a few comments

Hey @lizozom, I'm not seeing any other comments, perhaps Github swallowed them?

@kobelb kobelb merged commit 41b326e into elastic:master Jun 6, 2019
@kobelb kobelb deleted the docs/readonly-apps branch June 6, 2019 15:08
kobelb added a commit to kobelb/kibana that referenced this pull request Jun 6, 2019
…elastic#35560)

* Adding read-only mode section to Discover

* No more "mode" or "badge" terminology

* Putting newline back

* Adding "Saving" section for visualize

* Adding dashboard read only access section

* Timelion gets read-only documentation

* Adding read only access section to index patterns and advanced settings

* Adding graph read only access section
kobelb added a commit to kobelb/kibana that referenced this pull request Jun 6, 2019
…elastic#35560)

* Adding read-only mode section to Discover

* No more "mode" or "badge" terminology

* Putting newline back

* Adding "Saving" section for visualize

* Adding dashboard read only access section

* Timelion gets read-only documentation

* Adding read only access section to index patterns and advanced settings

* Adding graph read only access section
@lizozom
Copy link
Contributor

lizozom commented Jun 10, 2019

@kobelb forgot to submit my review.
But they were just a few text redactions.

Looks good!

kobelb added a commit that referenced this pull request Jun 13, 2019
…#35560) (#38306)

* Adding read-only mode section to Discover

* No more "mode" or "badge" terminology

* Putting newline back

* Adding "Saving" section for visualize

* Adding dashboard read only access section

* Timelion gets read-only documentation

* Adding read only access section to index patterns and advanced settings

* Adding graph read only access section
kobelb added a commit that referenced this pull request Jun 13, 2019
…#35560) (#38307)

* Adding read-only mode section to Discover

* No more "mode" or "badge" terminology

* Putting newline back

* Adding "Saving" section for visualize

* Adding dashboard read only access section

* Timelion gets read-only documentation

* Adding read only access section to index patterns and advanced settings

* Adding graph read only access section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants