[Watcher] Refine copy and layout of Watch History detail panel. #35462
Conversation
cjcenizal
added
non-issue
|
Pinging @elastic/es-ui |
💔 Build Failed |
There was a problem hiding this comment.
@cjcenizal fixes look great! I left a couple comments. Two are unrelated to your changes, but just something I noticed while reviewing.
|
|
||
| <EuiSpacer size="s" /> | ||
|
|
||
| <EuiCodeBlock language="javascript">{executionDetail}</EuiCodeBlock> |
There was a problem hiding this comment.
what do you think about changing the language prop to json?
|
|
||
| <EuiInMemoryTable | ||
| items={(itemDetail.watchStatus as any).actionStatuses} | ||
| itemId="id" |
| <FormattedMessage | ||
| id="xpack.watcher.sections.watchHistory.watchHistoryDetail.title" | ||
| defaultMessage="Executed on {date}" | ||
| values={{ date: itemDetail.startTime}} |
There was a problem hiding this comment.
getting a linting error here
There was a problem hiding this comment.
I think startTime needs to be added here: https://github.com/elastic/kibana/pull/35462/files#diff-e8768854560d1a6f237a10f5fe4b237dL43
|
@cjcenizal One other thing I just thought of :) We should probably update the simulation flyout as well to align. (It doesn't have to be this PR, just mentioning it here.)
|
💔 Build Failed |
|
Thanks for your review @alisonelizabeth! I've implemented your suggestions. Here's how the UI looks now:
|
|
@alisonelizabeth I'll work on that simulation flyout next. Thanks for mentioning that! |
💔 Build Failed |
💚 Build Succeeded |
cjcenizal
force-pushed
the
watcher/history-flyout-padding
branch
from
69ef929
to
7a94157
Compare
💚 Build Succeeded |
This PR also internationalizes some copy.