Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Platform] Validate config upfront #35453

Merged
merged 24 commits into from
May 10, 2019
Merged

[New Platform] Validate config upfront #35453

merged 24 commits into from
May 10, 2019
+524 −233

Commits on Apr 23, 2019

  1. Introduce new convention for config definition. 

    We need to define a way to acquire configuration schema as a part of
plugin definition. Having schema we can split steps of
config validation and plugin instantiation.
    @mshustov
    mshustov committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    c8f3ce6 View commit details
    Browse the repository at this point in the history

  2. Discover plugins, read their schema and validate the config. 

    Config validation finished before core services and plugins read from it.
That allows us to fail fast and have predictable validation results.
    @mshustov
    mshustov committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    1d37d47 View commit details
    Browse the repository at this point in the history

  3. Instantiate plugins using DiscoveredPluginsDefinitions.

    @mshustov
    mshustov committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    0b9d5a8 View commit details
    Browse the repository at this point in the history

  4. Update tests for new API.

    @mshustov
    mshustov committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    532089a View commit details
    Browse the repository at this point in the history

  5. test server is not created if config validation fails

    @mshustov
    mshustov committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    4d805ad View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Merge branch 'master' into issue-20303-validate-config-upfront

    @mshustov
    mshustov committed May 3, 2019
    Configuration menu
    Copy the full SHA
    001efc6 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2019

  1. move plugin discovery to plugin service pre-setup stage. 

    Set validation schemes in ConfigService.preSetup stage.
    @mshustov
    mshustov committed May 5, 2019
    Configuration menu
    Copy the full SHA
    a09520b View commit details
    Browse the repository at this point in the history

  2. fix eslint problem

    @mshustov
    mshustov committed May 5, 2019
    Configuration menu
    Copy the full SHA
    75d01ee View commit details
    Browse the repository at this point in the history

Commits on May 6, 2019

  1. Merge branch 'master' into issue-20303-validate-config-upfront

    @mshustov
    mshustov committed May 6, 2019
    Configuration menu
    Copy the full SHA
    1c3dfa7 View commit details
    Browse the repository at this point in the history

  2. generate docs

    @mshustov
    mshustov committed May 6, 2019
    Configuration menu
    Copy the full SHA
    924fc22 View commit details
    Browse the repository at this point in the history

  3. address Rudolfs comments

    @mshustov
    mshustov committed May 6, 2019
    Configuration menu
    Copy the full SHA
    be8dc61 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2019

  1. separate core services and plugins validation

    @mshustov
    mshustov committed May 8, 2019
    Configuration menu
    Copy the full SHA
    c0a98eb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue-20303-validate-config-upfront

    @mshustov
    mshustov committed May 8, 2019
    Configuration menu
    Copy the full SHA
    4b582d1 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2019

  1. rename files for consistency

    @mshustov
    mshustov committed May 9, 2019
    Configuration menu
    Copy the full SHA
    be4e4d3 View commit details
    Browse the repository at this point in the history

  2. address comments for root.js

    @mshustov
    mshustov committed May 9, 2019
    Configuration menu
    Copy the full SHA
    09cf5f2 View commit details
    Browse the repository at this point in the history

  3. address comments #1

    @mshustov
    mshustov committed May 9, 2019
    Configuration menu
    Copy the full SHA
    19c02c4 View commit details
    Browse the repository at this point in the history

  4. useSchema everywhere for consistency. get rid of validateAll

    @mshustov
    mshustov committed May 9, 2019
    Configuration menu
    Copy the full SHA
    e622cd3 View commit details
    Browse the repository at this point in the history

  5. plugin system runs plugin config validation

    @mshustov
    mshustov committed May 9, 2019
    Configuration menu
    Copy the full SHA
    f90711a View commit details
    Browse the repository at this point in the history

  6. rename configDefinition

    @mshustov
    mshustov committed May 9, 2019
    Configuration menu
    Copy the full SHA
    12d9947 View commit details
    Browse the repository at this point in the history

  7. move plugin schema registration in plugins plugins service 

    plugins system is not setup when kibana is run in optimizer mode,
so config keys aren't marked as applied.
    @mshustov
    mshustov committed May 9, 2019
    Configuration menu
    Copy the full SHA
    2a01ed7 View commit details
    Browse the repository at this point in the history

  8. cleanup

    @mshustov
    mshustov committed May 9, 2019
    Configuration menu
    Copy the full SHA
    1345904 View commit details
    Browse the repository at this point in the history

  9. update docs

    @mshustov
    mshustov committed May 9, 2019
    Configuration menu
    Copy the full SHA
    48c99cb View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into issue-20303-validate-config-upfront

    @mshustov
    mshustov committed May 9, 2019
    Configuration menu
    Copy the full SHA
    b8cc18a View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. address comments

    @mshustov
    mshustov committed May 10, 2019
    Configuration menu
    Copy the full SHA
    de341ac View commit details
    Browse the repository at this point in the history