-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Platform] Validate config upfront #35453
Merged
mshustov
merged 24 commits into
elastic:master
from
mshustov:issue-20303-validate-config-upfront
May 10, 2019
Merged
[New Platform] Validate config upfront #35453
mshustov
merged 24 commits into
elastic:master
from
mshustov:issue-20303-validate-config-upfront
May 10, 2019
+524
−233
Commits on Apr 23, 2019
-
Introduce new convention for config definition.
We need to define a way to acquire configuration schema as a part of plugin definition. Having schema we can split steps of config validation and plugin instantiation.
Configuration menu - View commit details
-
Copy full SHA for c8f3ce6 - Browse repository at this point
Copy the full SHA c8f3ce6View commit details -
Discover plugins, read their schema and validate the config.
Config validation finished before core services and plugins read from it. That allows us to fail fast and have predictable validation results.
Configuration menu - View commit details
-
Copy full SHA for 1d37d47 - Browse repository at this point
Copy the full SHA 1d37d47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b9d5a8 - Browse repository at this point
Copy the full SHA 0b9d5a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 532089a - Browse repository at this point
Copy the full SHA 532089aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d805ad - Browse repository at this point
Copy the full SHA 4d805adView commit details
Commits on May 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 001efc6 - Browse repository at this point
Copy the full SHA 001efc6View commit details
Commits on May 5, 2019
-
move plugin discovery to plugin service pre-setup stage.
Set validation schemes in ConfigService.preSetup stage.
Configuration menu - View commit details
-
Copy full SHA for a09520b - Browse repository at this point
Copy the full SHA a09520bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75d01ee - Browse repository at this point
Copy the full SHA 75d01eeView commit details
Commits on May 6, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 1c3dfa7 - Browse repository at this point
Copy the full SHA 1c3dfa7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 924fc22 - Browse repository at this point
Copy the full SHA 924fc22View commit details -
Configuration menu - View commit details
-
Copy full SHA for be8dc61 - Browse repository at this point
Copy the full SHA be8dc61View commit details
Commits on May 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c0a98eb - Browse repository at this point
Copy the full SHA c0a98ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b582d1 - Browse repository at this point
Copy the full SHA 4b582d1View commit details
Commits on May 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for be4e4d3 - Browse repository at this point
Copy the full SHA be4e4d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09cf5f2 - Browse repository at this point
Copy the full SHA 09cf5f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19c02c4 - Browse repository at this point
Copy the full SHA 19c02c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e622cd3 - Browse repository at this point
Copy the full SHA e622cd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f90711a - Browse repository at this point
Copy the full SHA f90711aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12d9947 - Browse repository at this point
Copy the full SHA 12d9947View commit details -
move plugin schema registration in plugins plugins service
plugins system is not setup when kibana is run in optimizer mode, so config keys aren't marked as applied.
Configuration menu - View commit details
-
Copy full SHA for 2a01ed7 - Browse repository at this point
Copy the full SHA 2a01ed7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1345904 - Browse repository at this point
Copy the full SHA 1345904View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48c99cb - Browse repository at this point
Copy the full SHA 48c99cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8cc18a - Browse repository at this point
Copy the full SHA b8cc18aView commit details
Commits on May 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for de341ac - Browse repository at this point
Copy the full SHA de341acView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.