Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Watcher] Handle 403 and 404 in Status and Edit routes and fix breadcrumbs #35444

Merged
merged 11 commits into from
Apr 23, 2019
Merged

[Watcher] Handle 403 and 404 in Status and Edit routes and fix breadcrumbs #35444

merged 11 commits into from
Apr 23, 2019

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Apr 23, 2019 •
edited
Loading

When the user lacks permissions to manage watches, they'll see some feedback and be blocked from using the UI:

image

Currently, this only works for the edit and status routes. There's code in place to do this for the list route, but it looks like the API for fetching and listing all watches is just a simple search, and it doesn't look like the user's watch permissions affect this query. I'll follow up with the Watcher API team on this.

I also added feedback for when the API responds with a 404:

image

@cjcenizal cjcenizal added non-issue Indicates to automation that a pull request should not appear in the release notes Feature:Watcher Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Apr 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@cjcenizal cjcenizal changed the title Watcher/forbidden state [Watcher] Handle 403s in Status and Edit routes Apr 23, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal cjcenizal changed the title [Watcher] Handle 403s in Status and Edit routes [Watcher] Handle 403 and 404 in Status and Edit routes Apr 23, 2019
@cjcenizal cjcenizal changed the title [Watcher] Handle 403 and 404 in Status and Edit routes [Watcher] Handle 403 and 404 in Status and Edit routes and fix breadcrumbs Apr 23, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

bmcconaghy
bmcconaghy approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx for all the fixes

alisonelizabeth
alisonelizabeth approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal merged commit 3e1767b into elastic:watcher-port Apr 23, 2019
@cjcenizal cjcenizal deleted the watcher/forbidden-state branch April 23, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcconaghy bmcconaghy bmcconaghy approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
Feature:Watcher non-issue Indicates to automation that a pull request should not appear in the release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjcenizal @elasticmachine @bmcconaghy @alisonelizabeth