Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force consistent canvasCheckered colors #33786

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Mar 25, 2019

Summary

Closes #33604

The .canvasCheckered class adds the "#DDD" diamond pattern over whatever background color it inherits. On Dark Mode, that color is #1D1E24 which is very dark and causes the bad contrast.

This PR forces the canvasCheckered background to always be white, so it will be consistent on every theme.

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@crob611 crob611 added v7.0.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.2.0 labels Mar 25, 2019
@crob611 crob611 requested a review from a team as a code owner March 25, 2019 15:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Simple fix, thanks for knocking this one out!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@crob611 crob611 removed the v7.0.0 label Mar 26, 2019
@crob611 crob611 merged commit f244583 into elastic:master Mar 27, 2019
crob611 added a commit to crob611/kibana that referenced this pull request Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants