Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted bar, progress and progressbar directives #33585

Merged
merged 7 commits into from
Mar 24, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Mar 20, 2019

Deleted directives

  • progress
  • bar
  • progressbar

Changed

  • implementation of Discover > string field > proressbar to use EUI progressbar and tooltip.

The new implementation:
image

The old implemtation:
image

The big difference is that the EUI progress bar doesn't support showing the absolute value on the bar, so I have placed it next to the progress bar instead.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

- progress
- bar
- progressbar

Changed
 - implementation of Discover > string field > proressbar to use EUI progressbar and tooltip.
@lizozom lizozom requested a review from a team as a code owner March 20, 2019 17:05
@lizozom lizozom self-assigned this Mar 20, 2019
@lizozom lizozom added Feature:New Platform EUI Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.2.0 labels Mar 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom
Copy link
Contributor Author

lizozom commented Mar 20, 2019

elastic/eui#1749

@ryankeairns
Copy link
Contributor

@lizozom This is looking nice! One thing that seems to be missing between the old and new is that the length of the progress bar (background) conveyed additional information - presumably, it is the % each individual category makes up of the entire record set? Perhaps that was intentionally removed, please disregard if that is the case.

Separately, I think Dave recently made a change where the filtering icons (magnifying glass +/-) only display on hover since they repeat visually. He made this change in the list/table portion of the Discover page (I think), and it would be nice to do the same, here, although this could also be done in a separate PR.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom
Copy link
Contributor Author

lizozom commented Mar 20, 2019

@ryankeairns Thanks for reviewing this!
The length of the progressbar actually didn't convey additional information.
I found that confusing as well. The total length of the progress bar was defined by the percentage, and the "white part" is actually just created by the number. The absolute amount of items in each bucket is shown using a tooltip in both cases.

I also found the "magnifying lens" icons current design unappealing, but I think that this should be done in a separate PR.

@ryankeairns
Copy link
Contributor

@lizozom aha! In that case, this new design definitely seems more accurate :)

We (the design team) can get those icons cleaned up. It's a little busy over there, but there is a pattern on how to improve it. Thanks!

@lizozom lizozom requested review from lukeelmers and mattkime March 21, 2019 08:29
@lizozom
Copy link
Contributor Author

lizozom commented Mar 21, 2019

@ryankeairns if so would you mind approving?

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom merged commit 6a2e22f into elastic:master Mar 24, 2019
lizozom added a commit to lizozom/kibana that referenced this pull request Mar 24, 2019
* Deleted
- progress
- bar
- progressbar

Changed
 - implementation of Discover > string field > proressbar to use EUI progressbar and tooltip.

* added bug comment

* Fixed CR
lizozom added a commit that referenced this pull request Mar 24, 2019
* Deleted
- progress
- bar
- progressbar

Changed
 - implementation of Discover > string field > proressbar to use EUI progressbar and tooltip.
@stacey-gammon stacey-gammon mentioned this pull request Mar 26, 2019
94 tasks
@timroes timroes added the chore label Mar 27, 2019
joelgriffith pushed a commit that referenced this pull request Mar 27, 2019
* Deleted
- progress
- bar
- progressbar

Changed
 - implementation of Discover > string field > proressbar to use EUI progressbar and tooltip.

* added bug comment

* Fixed CR
@lizozom lizozom deleted the new-platform-delete-progressbar branch April 21, 2019 10:46
@cchaos cchaos added EUI and removed Feature:EUI labels Aug 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore EUI Feature:New Platform Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants