-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleted bar, progress and progressbar directives #33585
Deleted bar, progress and progressbar directives #33585
Conversation
Pinging @elastic/kibana-app |
💚 Build Succeeded |
@lizozom This is looking nice! One thing that seems to be missing between the old and new is that the length of the progress bar (background) conveyed additional information - presumably, it is the % each individual category makes up of the entire record set? Perhaps that was intentionally removed, please disregard if that is the case. Separately, I think Dave recently made a change where the filtering icons (magnifying glass +/-) only display on hover since they repeat visually. He made this change in the list/table portion of the Discover page (I think), and it would be nice to do the same, here, although this could also be done in a separate PR. |
💚 Build Succeeded |
@ryankeairns Thanks for reviewing this! I also found the "magnifying lens" icons current design unappealing, but I think that this should be done in a separate PR. |
@lizozom aha! In that case, this new design definitely seems more accurate :) We (the design team) can get those icons cleaned up. It's a little busy over there, but there is a pattern on how to improve it. Thanks! |
@ryankeairns if so would you mind approving? |
src/legacy/core_plugins/kibana/public/discover/components/field_chooser/_field_chooser.scss
Outdated
Show resolved
Hide resolved
…kibana into new-platform-delete-progressbar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
💚 Build Succeeded |
* Deleted - progress - bar - progressbar Changed - implementation of Discover > string field > proressbar to use EUI progressbar and tooltip. * added bug comment * Fixed CR
* Deleted - progress - bar - progressbar Changed - implementation of Discover > string field > proressbar to use EUI progressbar and tooltip. * added bug comment * Fixed CR
Pinging @elastic/eui-design (EUI) |
Deleted directives
Changed
The new implementation:
![image](https://user-images.githubusercontent.com/3016806/54704429-60c62080-4b43-11e9-9054-e050661dcf14.png)
The old implemtation:
![image](https://user-images.githubusercontent.com/3016806/54704397-5146d780-4b43-11e9-8a9e-af50f966ec46.png)
The big difference is that the EUI progress bar doesn't support showing the absolute value on the bar, so I have placed it next to the progress bar instead.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenariosFor maintainers