-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert saved objects UI to use new import / export API #33513
Convert saved objects UI to use new import / export API #33513
Conversation
Pinging @elastic/kibana-platform |
dcf5fa5
to
ded07a4
Compare
ded07a4
to
f57ae8f
Compare
Jenkins, test this |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
95088f9
to
3ed632d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@gchaps I'm trying to find a better alternative than For example exporting a dashboard with the option enabled will include visualizations, saved search, index patterns etc that the dashboard would need. It is a recursive option to gather all referenced objects. Thoughts? |
@epixa should the option to include nested references be turned on by default? (as I have in the screenshot above) |
This comment has been minimized.
This comment has been minimized.
@mikecote works for me! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, still have a few things to review and test.
...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js
Show resolved
Hide resolved
...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js
Outdated
Show resolved
Hide resolved
...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js
Show resolved
Hide resolved
...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js
Outdated
Show resolved
Hide resolved
...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
…status variable instead
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js
Outdated
Show resolved
Hide resolved
...kibana/public/management/sections/objects/components/objects_table/components/table/table.js
Outdated
Show resolved
Hide resolved
...ugins/kibana/public/management/sections/objects/lib/__jest__/process_import_response.test.js
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/management/sections/objects/lib/resolve_import_errors.js
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the various edge cases and it all LGTM. Thanks for refactoring some of the logic for testability.
* Initial work converting UI to use new server side APIs * Remove missed file * Fix jest tests * Code cleanup pt1 * Fix file casing * Fix jest tests * Modify UI to support including nested references * Fix button layout * Connect includeReferencesDeep, remove references_missing_references logic * Fix broken tests * Cleanup * Display success notifications and auto close modals on export * More code cleanup * Log to server when user imports using legacy .json file * Final cleanup * Update test snapshots to match updated text * Apply PR feedback pt1 * Remove isLoading and wasImportSuccessful state variables, use single status variable instead * Move business logic out of flyout component * Apply PR feedback * Update wordings
) * Initial work converting UI to use new server side APIs * Remove missed file * Fix jest tests * Code cleanup pt1 * Fix file casing * Fix jest tests * Modify UI to support including nested references * Fix button layout * Connect includeReferencesDeep, remove references_missing_references logic * Fix broken tests * Cleanup * Display success notifications and auto close modals on export * More code cleanup * Log to server when user imports using legacy .json file * Final cleanup * Update test snapshots to match updated text * Apply PR feedback pt1 * Remove isLoading and wasImportSuccessful state variables, use single status variable instead * Move business logic out of flyout component * Apply PR feedback * Update wordings
* Initial work converting UI to use new server side APIs * Remove missed file * Fix jest tests * Code cleanup pt1 * Fix file casing * Fix jest tests * Modify UI to support including nested references * Fix button layout * Connect includeReferencesDeep, remove references_missing_references logic * Fix broken tests * Cleanup * Display success notifications and auto close modals on export * More code cleanup * Log to server when user imports using legacy .json file * Final cleanup * Update test snapshots to match updated text * Apply PR feedback pt1 * Remove isLoading and wasImportSuccessful state variables, use single status variable instead * Move business logic out of flyout component * Apply PR feedback * Update wordings
This PR changes the saved objects management UI to use the new server side APIs for import / export. This also keeps backwards compatibility for old exports (.json files) but displays a warning message that the feature is deprecated.
Other changes in this PR:
.json
filesFixes #27306
Fixes #22550
Fixes #23557
Fixes #29747
Fixes #25020