Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Strictly pick fields sent upon source config creation #32897

Conversation

weltenwort
Copy link
Member

Summary

This picks the specific fields to submit for source configuration creation instead of just passing through the object. Before this, the newly included message field configuration would be erroneously included and lead to an error.

Checklist

For maintainers

@weltenwort weltenwort added v7.0.0 [zube]: In Progress Feature:Metrics UI Metrics UI feature v8.0.0 Feature:Logs UI Logs UI feature v6.7.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.2.0 labels Mar 11, 2019
@weltenwort weltenwort self-assigned this Mar 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@alvarolobato alvarolobato added the bug Fixes for quality problems that affect the customer experience label Mar 11, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weltenwort weltenwort merged commit c5f27b3 into elastic:master Mar 12, 2019
weltenwort added a commit to weltenwort/kibana that referenced this pull request Mar 12, 2019
…stic#32897)

This picks the specific fields to submit for source configuration creation instead of just passing through the object. Before this, the newly included `message` field configuration would be erroneously included and lead to an error.
weltenwort added a commit to weltenwort/kibana that referenced this pull request Mar 12, 2019
…stic#32897)

This picks the specific fields to submit for source configuration creation instead of just passing through the object. Before this, the newly included `message` field configuration would be erroneously included and lead to an error.
weltenwort added a commit that referenced this pull request Mar 12, 2019
#32897) (#32990)

Backports the following commits to 6.7:
 - [Infra UI] Strictly pick fields sent upon source config creation  (#32897)
weltenwort added a commit that referenced this pull request Mar 12, 2019
#32897) (#32989)

Backports the following commits to 7.0:
 - [Infra UI] Strictly pick fields sent upon source config creation  (#32897)
weltenwort added a commit to weltenwort/kibana that referenced this pull request Mar 12, 2019
…stic#32897)

This picks the specific fields to submit for source configuration creation instead of just passing through the object. Before this, the newly included `message` field configuration would be erroneously included and lead to an error.
weltenwort added a commit that referenced this pull request Mar 13, 2019
#32897) (#32988)

Backports the following commits to 7.x:
 - [Infra UI] Strictly pick fields sent upon source config creation  (#32897)
@weltenwort weltenwort added the non-issue Indicates to automation that a pull request should not appear in the release notes label May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature non-issue Indicates to automation that a pull request should not appear in the release notes review Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v6.7.0 v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants