Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timelion/hide timelion #30131

Merged
merged 3 commits into from
Feb 5, 2019
Merged

Conversation

chrisdavies
Copy link
Contributor

Timelion sheets will continue to work in visualize, but the application
will no longer appear in the app switcher by default. The
timelion.ui.enabled configuration in kibana.yml will toggle the app on.

epixa and others added 3 commits January 31, 2019 21:05
Timelion sheets will continue to work in visualize, but the application
will no longer appear in the app switcher by default. The
timelion.ui.enabled configuration in kibana.yml will toggle the app on.
@epixa epixa added blocker Feature:Timelion Timelion app and visualization blocker-ff Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - no concerns on my end, assuming the build comes back green.

Tested locally (Chrome OSX), and verified the app switcher icon is hidden by default, but everything else (including hitting the app landing page directly at /app/timelion) continues to function as normal. Icon displays as it used to when the setting is enabled in kibana.yml.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@chrisdavies chrisdavies merged commit 43fdf9c into elastic:master Feb 5, 2019
@chrisdavies chrisdavies deleted the timelion/hide-timelion branch February 5, 2019 21:14
@AlonaNadler
Copy link

@chrisdavies thanks for jumping on this :)
Can we make sure that any existing Timelion sheets done in the Timelion application work properly after users enable Timelion application? I want to make sure we are not breaking anything

@cchaos
Copy link
Contributor

cchaos commented Feb 6, 2019

So should the Timelion advanced settings still be visible by default? Like the rows/columns and tutorial stuff?

screen shot 2019-02-05 at 20 02 58 pm

screen shot 2019-02-05 at 20 01 09 pm

@chrisdavies
Copy link
Contributor Author

Hm. @cchaos I only hopped on this because Court didn't have time to wrap it up. I honestly don't know anything about timelion. @AlonaNadler thoughts about @cchaos's question?

@AlonaNadler
Copy link

Would be nice to have if when Timelion is disabled the other Timelion related settings (tutorial, rows, and columns) are disabled as well, not the highest priority but will be nice to have

@timroes
Copy link
Contributor

timroes commented Feb 11, 2019

@AlonaNadler Could you please create a separate issue for this, since I am not sure if that would still go into 7.0, since it's a new feature (and concept, we don't disable settings like that yet anywhere).

@AlonaNadler
Copy link

@timroes I already opened an issue for that #30141
The reason it's important to be in 7.0 is that is breaking change, @epixa suggested that it is a relatively minor change. The main priority is to have a new setting that will hide Timelion application globally in Kibana, Timelion application should be hidden by default

@gchaps
Copy link
Contributor

gchaps commented Feb 11, 2019

@chrisdavies Could you please add this change to the 7.0 Breaking Changes doc?

@chrisdavies
Copy link
Contributor Author

@gchaps I'm not familiar with that doc. Where is it?

@gchaps
Copy link
Contributor

gchaps commented Feb 11, 2019

@chrisdavies You'll find the doc at kibana/docs/migration/migrate_7_0.asciidoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:Timelion Timelion app and visualization release_note:breaking Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants