move optimize into data folder #25944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-operations |
|
Do we have any public documentation mentioning the previous location? |
|
@jbudz I have to little questions. Should we also update |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
epixa
reviewed
Nov 21, 2018
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
|
nit: can remove |
💚 Build Succeeded |
2 tasks
💚 Build Succeeded |
jbudz
added
the
non-issue
|
Getting this ready again - I wanted to wait to avoid workflow interruptions when switching between 8.x and 7.x but at the same time don't want to wait too long :) |
jbudz
added
release_note:skip
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Sep 24, 2019
We can either remove the legacy optimize directory from gitignore, or we can add to eslintignore. We have choosen to go with the latter o prevent accidental commits of the optimize directory and a smoother transition between old branches. This change was made in elastic#25944 and only effects master/8.0, which increases the likelyhood a developer runs into it. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Sep 24, 2019
We can either remove the legacy optimize directory from gitignore, or we can add to eslintignore. We have chosen to go with the latter to prevent accidental commits of the optimize directory and aide in a smoother transition between old branches. This change was made in elastic#25944 and only effects master/8.0, which increases the likelihood a developer runs into it. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
pushed a commit
that referenced
this pull request
Sep 24, 2019
We can either remove the legacy optimize directory from gitignore, or we can add to eslintignore. We have chosen to go with the latter to prevent accidental commits of the optimize directory and aide in a smoother transition between old branches. This change was made in #25944 and only effects master/8.0, which increases the likelihood a developer runs into it. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a general purpose data folder used for application writes, and there's some overlap with this and the optimize folder. We want all writes to go to the same folder so we can set this path to /var/lib/kibana for deb/rpm packages.
https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s08.html
Currently in the data folder we'll extract phantomjs, create a uuid, and store the keystore. This moves bundles and bundle caches there in addition
Closes #15899
Closes #5071