Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Euify and Reactify Query Bar Component (#23704) #24420

Merged
merged 1 commit into from
Oct 23, 2018
Merged

[6.x] Euify and Reactify Query Bar Component (#23704) #24420

merged 1 commit into from
Oct 23, 2018
+2,699 −1,414

Commits on Oct 23, 2018

  1. Euify and Reactify Query Bar Component (elastic#23704) 

    Implements query bar portion of https://elastic.github.io/eui/#/layout/header. Filter bar will come in another PR.

Fixes elastic#14086

Re-implements our query bar component in React using some EUI components. Existing typeahead and suggestion styles were copied over 1:1 for now after talking with Dave about it. In this PR I focused on reaching feature parity with the existing query bar. Some additional work would be needed before we could move this into EUI as a generic component that could be consumed by other plugins.

Still needs some new tests and I suspect some old tests will need to be updated, but other than that this PR is functionally complete and ready for reviews.
    @Bargs
    Bargs committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    2672db9 View commit details
    Browse the repository at this point in the history