Code

[WIP] Securing Spaces#21995

Code

Merged

kobelb merged 88 commits intoelastic:spaces-phase-1elastic/kibana:spaces-phase-1from kobelb:spaces/securingkobelb/kibana:spaces/securingCopy head branch name to clipboardSep 12, 2018

+16,618-5,225

Commits

Commits on Aug 2, 2018

• Splitting to a client and a wrapper, integation tests are passing

  Show description for a25ed8e
  kobelb

  committed
  a25ed8e

  Copy full SHA for a25ed8e

Commits on Aug 3, 2018

• Adding the spaces wrapper back in the mix using a priority collection

  kobelb

  committed
  e0a83cd

  Copy full SHA for e0a83cd

• Restructuring the secure wrapper as we don't need to switch between

  Show description for f937154
  kobelb

  committed
  f937154

  Copy full SHA for f937154

• Checking authorization at the current space

  kobelb

  committed
  591a31b

  Copy full SHA for 591a31b

Commits on Aug 6, 2018

• Beginning to make the rbac api integration tests run against spaces

  kobelb

  committed
  dbfe32e

  Copy full SHA for dbfe32e

• Adding identical data to the rbac esArchives for two more spaces

  kobelb

  committed
  d25514a

  Copy full SHA for d25514a

• Adding some space tests for find

  kobelb

  committed
  7ed4332

  Copy full SHA for 7ed4332

Commits on Aug 8, 2018

• Beginning to work on the spaces client

  kobelb

  committed
  43322c2

  Copy full SHA for 43322c2

• Fixing find and filtering out unrequested privileges from response

  kobelb

  committed
  daad804

  Copy full SHA for daad804

• Adding get code and test

  kobelb

  committed
  d5b9b53

  Copy full SHA for d5b9b53

Commits on Aug 10, 2018

• Introducing an RBAC Auth Scope

  kobelb

  committed
  74335fa

  Copy full SHA for 74335fa

• Exposing the spacesClient a bit better

  kobelb

  committed
  706c505

  Copy full SHA for 706c505

Commits on Aug 13, 2018

• Moving the server.expose to the security plugin init

  kobelb

  committed
  e0a6c6f

  Copy full SHA for e0a6c6f

• Moving checkPrivilegesAtAllResources to it's own thing

  kobelb

  committed
  5487f0f

  Copy full SHA for 5487f0f

• No longer using the auth scope for RBAC, dashboard mode didn't work with

  Show description for 69b1eb6
  kobelb

  committed
  69b1eb6

  Copy full SHA for 69b1eb6

Commits on Aug 14, 2018

• Securing the create space method

  kobelb

  committed
  685b061

  Copy full SHA for 685b061

• Adding secure update method

  kobelb

  committed
  c7e390b

  Copy full SHA for c7e390b

• Adding secured delete endpoints

  kobelb

  committed
  6d5a15a

  Copy full SHA for 6d5a15a

• Restructuring some code in the spaces client

  kobelb

  committed
  e355ff0

  Copy full SHA for e355ff0

• Adding tests for the select endpoint

  kobelb

  committed
  67b64e9

  Copy full SHA for 67b64e9

Commits on Aug 15, 2018

• Spaces can't be managed via the SavedObjectsClient now

  kobelb

  committed
  52633f0

  Copy full SHA for 52633f0

• Creating separate space_all and space_read privileges

  kobelb

  committed
  d2ab5cc

  Copy full SHA for d2ab5cc

Commits on Aug 17, 2018

• Merge branch 'spaces-phase-1' into spaces/securing

  kobelb

  committed
  cff7c61

  Copy full SHA for cff7c61

Commits on Aug 20, 2018

• Splitting out the spaces and global privileges

  kobelb

  committed
  b827684

  Copy full SHA for b827684

• Merge branch 'spaces-phase-1' into spaces/securing

  kobelb

  committed
  ed54020

  Copy full SHA for ed54020

• Fixing edit role screen after API changes

  kobelb

  committed
  3d75fb3

  Copy full SHA for 3d75fb3

• Revising comment, there is a Set in JavaScript now, but lodash can't

  Show description for 151d4ee
  kobelb

  committed
  151d4ee

  Copy full SHA for 151d4ee

Commits on Aug 21, 2018

• Using authorization mode to log deprecation warning on login

  kobelb

  committed
  cec82a9

  Copy full SHA for cec82a9

Commits on Aug 22, 2018

• Changing the signature of checkPrivileges

  Show description for 5649e10
  kobelb

  committed
  5649e10

  Copy full SHA for 5649e10

• Refactoring the way we specify resources when checking privileges

  kobelb

  committed
  5995cae

  Copy full SHA for 5995cae

• Exposing the space service more intuitively

  kobelb

  committed
  b87b506

  Copy full SHA for b87b506

• Fixing comments

  kobelb

  committed
  13fdf1f

  Copy full SHA for 13fdf1f

• Security defines all actions

  kobelb

  committed
  588e2e8

  Copy full SHA for 588e2e8

Commits on Aug 23, 2018

• Renaming response returned by the checkPrivileges function

  kobelb

  committed
  87a8332

  Copy full SHA for 87a8332

Commits on Aug 28, 2018

• Merge remote-tracking branch 'upstream/spaces-phase-1' into spaces/securing

  kobelb

  committed
  58f037c

  Copy full SHA for 58f037c

• Hard-coding the kibana app privileges teporarily

  kobelb

  committed
  e64ec72

  Copy full SHA for e64ec72

• Adding Authenticator authorization mode tests

  kobelb

  committed
  daca66b

  Copy full SHA for daca66b

• Adding actions.manageSpaces tests

  kobelb

  committed
  8ee733f

  Copy full SHA for 8ee733f

• Adding check privileges tests

  kobelb

  committed
  58aa6f1

  Copy full SHA for 58aa6f1

• Fixing checkPrivileges test snapshots

  kobelb

  committed
  18e058f

  Copy full SHA for 18e058f

• Making sure tests fail until I correct this deficiency

  kobelb

  committed
  3813a12

  Copy full SHA for 3813a12

• Adding stubbed out authorization mode tests

  kobelb

  committed
  a50d51a

  Copy full SHA for a50d51a

• Fixing tests for RegisterPrivilegesWithCluster

  kobelb

  committed
  4dfb720

  Copy full SHA for 4dfb720

• Fixing service AuthorizationService tests

  kobelb

  committed
  2a632f0

  Copy full SHA for 2a632f0

Commits on Aug 29, 2018

• Addinng serializer tests

  kobelb

  committed
  e3b23e6

  Copy full SHA for e3b23e6

• Adding validateEsResponse tests

  kobelb

  committed
  1f5c127

  Copy full SHA for 1f5c127

• We don't need the SecureSavedObjectsClient anymore!

  kobelb

  committed
  31cc9ff

  Copy full SHA for 31cc9ff

• Adding SecureSavedObjectsClientWrapper tests...

  kobelb

  committed
  ac3d143

  Copy full SHA for ac3d143

Commits on Sep 4, 2018

• Merge remote-tracking branch 'upstream/spaces-phase-1' into spaces/securing

  kobelb

  committed
  aefe2c5

  Copy full SHA for aefe2c5

• Fixing a few stray tests

  kobelb

  committed
  ce171ca

  Copy full SHA for ce171ca

• Fixing issue when user isn't authenticated and check useRbacForRequest

  kobelb

  committed
  cef2e78

  Copy full SHA for cef2e78

Commits on Sep 5, 2018

• Merge remote-tracking branch 'upstream/spaces-phase-1' into spaces/securing

  kobelb

  committed
  7b4575b

  Copy full SHA for 7b4575b

Commits on Sep 7, 2018

• Validating spaces we're adding to roles

  kobelb

  committed
  5413b47

  Copy full SHA for 5413b47

• Reusing hasAnyPrivileges from hasAnyResourcePrivileges

  kobelb

  committed
  c02d0fb

  Copy full SHA for c02d0fb

• Better variable name

  kobelb

  committed
  1436495

  Copy full SHA for 1436495

• toArray -> toPrioritizedArray

  kobelb

  committed
  79884be

  Copy full SHA for 79884be

• Using Space throughout the SpacesClient

  kobelb

  committed
  b7d2aa4

  Copy full SHA for b7d2aa4

Commits on Sep 10, 2018

• GetActiveSpace uses the SpacesClient now

  kobelb

  committed
  14a1d96

  Copy full SHA for 14a1d96

• Squashed commit of the following:

  Show description for d9699f9
  kobelb

  committed
  d9699f9

  Copy full SHA for d9699f9

• Merge branch 'spaces-phase-1' into spaces/securing

  legrego

  committed
  6da2f05

  Copy full SHA for 6da2f05

• update public api to use SpacesClient

  legrego

  committed
  8e52fc0

  Copy full SHA for 8e52fc0

• fix

  legrego

  committed
  81b785b

  Copy full SHA for 81b785b

• test and api fixes

  legrego

  committed
  b3b04f3

  Copy full SHA for b3b04f3

• fix tests

  legrego

  committed
  fb40ad9

  Copy full SHA for fb40ad9

• Merge branch 'spaces-phase-1' into spaces/securing

  legrego

  committed
  eb3fde7

  Copy full SHA for eb3fde7

• Merge pull request #5 from legrego/spaces/securing-update

  Show description for f52e688
  kobelb

  authored
  f52e688

  Copy full SHA for f52e688

Commits on Sep 11, 2018

• Disallowing use of Spaces with the SpacesSavedObjectsClientWrapper

  kobelb

  committed
  88b03e7

  Copy full SHA for 88b03e7

• Adding spaces audit logging

  kobelb

  committed
  b2e4321

  Copy full SHA for b2e4321

• Updating snapshots

  kobelb

  committed
  454dcb1

  Copy full SHA for 454dcb1

• Adding get and getAll tests for the spaces client

  kobelb

  committed
  d01f9b6

  Copy full SHA for d01f9b6

Commits on Sep 12, 2018

• Adding update tests

  kobelb

  committed
  e3569c8

  Copy full SHA for e3569c8

• Adding create tests

  kobelb

  committed
  90b9811

  Copy full SHA for 90b9811

• Adding SpacesClient delete tests

  kobelb

  committed
  3d0a8f4

  Copy full SHA for 3d0a8f4

• Fixing authenticate tests

  kobelb

  committed
  a061555

  Copy full SHA for a061555

• Making tests more consistent

  kobelb

  committed
  b8d9738

  Copy full SHA for b8d9738

• Merge remote-tracking branch 'upstream/spaces-phase-1' into spaces/securing

  kobelb

  committed
  5e79942

  Copy full SHA for 5e79942

• Fixing kibana privileges tests

  kobelb

  committed
  54360a2

  Copy full SHA for 54360a2

• Fixing a few type issues

  kobelb

  committed
  ec1eeb7

  Copy full SHA for ec1eeb7

• Making typescript ignore the .only test suites

  kobelb

  committed
  6685a52

  Copy full SHA for 6685a52

• Switching to beforeEach and afterEach and removing the mocha types

  kobelb

  committed
  dea9859

  Copy full SHA for dea9859

• Switching to our own expect.js definitions

  Show description for d9dc42b
  kobelb

  committed
  d9dc42b

  Copy full SHA for d9dc42b

• Fixing more linting rules

  kobelb

  committed
  77538e8

  Copy full SHA for 77538e8

• Removing test stubs and replacing with TODOs. Updating snapshots

  kobelb

  committed
  b7fc11e

  Copy full SHA for b7fc11e

• No longer shadowing application for the put role API

  kobelb

  committed
  f59a2ee

  Copy full SHA for f59a2ee

• Relying on the errors thrown by the SpacedClient when determining active

  Show description for bbc54cb
  kobelb

  committed
  bbc54cb

  Copy full SHA for bbc54cb

• Back to after/before... mocha doesn't have beforeAll/afterAll

  kobelb

  committed
  aba3f39

  Copy full SHA for aba3f39

• We got them types, thanks Spencer!!!

  kobelb

  committed
  0a531b5

  Copy full SHA for 0a531b5

• Ignoring space type from the secure saved objects client find with no

  Show description for a68f029
  kobelb

  committed
  a68f029

  Copy full SHA for a68f029