[ES|QL] WHERE replacement ranges correctly generated for every case #209684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
drewdaemon
force-pushed
the
204441/where-fixes
branch
from
1669ca8 to
96a16e6
Compare
drewdaemon
added
release_note:fix
Feature:ES|QL
drewdaemon
added
v8.18.0
v9.1.0
backport:version
|
Pinging @elastic/kibana-esql (Team:ESQL) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
|
stratoula
approved these changes
Feb 6, 2025
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2025
…lastic#209684) ## Summary fix elastic#204441 It ain't beautiful but it works. I am going to come in with another pr to deal with prefix detection holistically ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 4ee3b50)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2025
…lastic#209684) ## Summary fix elastic#204441 It ain't beautiful but it works. I am going to come in with another pr to deal with prefix detection holistically ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 4ee3b50)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2025
…lastic#209684) ## Summary fix elastic#204441 It ain't beautiful but it works. I am going to come in with another pr to deal with prefix detection holistically ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 4ee3b50)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 6, 2025
…case (#209684) (#210052) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)](#209684) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T15:36:07Z","message":"[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/204441\r\n\r\nIt ain't beautiful but it works. I am going to come in with another pr\r\nto deal with prefix detection holistically\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4ee3b50584eec0d596a3aa3694a3d7047ba66002","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[ES|QL] WHERE replacement ranges correctly generated for every case","number":209684,"url":"https://github.com/elastic/kibana/pull/209684","mergeCommit":{"message":"[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/204441\r\n\r\nIt ain't beautiful but it works. I am going to come in with another pr\r\nto deal with prefix detection holistically\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4ee3b50584eec0d596a3aa3694a3d7047ba66002"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209684","number":209684,"mergeCommit":{"message":"[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/204441\r\n\r\nIt ain't beautiful but it works. I am going to come in with another pr\r\nto deal with prefix detection holistically\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4ee3b50584eec0d596a3aa3694a3d7047ba66002"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Drew Tate <drew.tate@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 6, 2025
…case (#209684) (#210053) # Backport This will backport the following commits from `main` to `9.0`: - [[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)](#209684) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T15:36:07Z","message":"[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/204441\r\n\r\nIt ain't beautiful but it works. I am going to come in with another pr\r\nto deal with prefix detection holistically\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4ee3b50584eec0d596a3aa3694a3d7047ba66002","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[ES|QL] WHERE replacement ranges correctly generated for every case","number":209684,"url":"https://github.com/elastic/kibana/pull/209684","mergeCommit":{"message":"[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/204441\r\n\r\nIt ain't beautiful but it works. I am going to come in with another pr\r\nto deal with prefix detection holistically\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4ee3b50584eec0d596a3aa3694a3d7047ba66002"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209684","number":209684,"mergeCommit":{"message":"[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/204441\r\n\r\nIt ain't beautiful but it works. I am going to come in with another pr\r\nto deal with prefix detection holistically\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4ee3b50584eec0d596a3aa3694a3d7047ba66002"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Drew Tate <drew.tate@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 6, 2025
… case (#209684) (#210051) # Backport This will backport the following commits from `main` to `8.18`: - [[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)](#209684) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T15:36:07Z","message":"[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/204441\r\n\r\nIt ain't beautiful but it works. I am going to come in with another pr\r\nto deal with prefix detection holistically\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4ee3b50584eec0d596a3aa3694a3d7047ba66002","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[ES|QL] WHERE replacement ranges correctly generated for every case","number":209684,"url":"https://github.com/elastic/kibana/pull/209684","mergeCommit":{"message":"[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/204441\r\n\r\nIt ain't beautiful but it works. I am going to come in with another pr\r\nto deal with prefix detection holistically\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4ee3b50584eec0d596a3aa3694a3d7047ba66002"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209684","number":209684,"mergeCommit":{"message":"[ES|QL] WHERE replacement ranges correctly generated for every case (#209684)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/204441\r\n\r\nIt ain't beautiful but it works. I am going to come in with another pr\r\nto deal with prefix detection holistically\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4ee3b50584eec0d596a3aa3694a3d7047ba66002"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Drew Tate <drew.tate@elastic.co>
drewdaemon
added a commit
to drewdaemon/kibana
that referenced
this pull request
Feb 6, 2025
…lastic#209684) fix elastic#204441 It ain't beautiful but it works. I am going to come in with another pr to deal with prefix detection holistically - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mariairiartef
pushed a commit
to mariairiartef/kibana
that referenced
this pull request
Feb 7, 2025
…lastic#209684) ## Summary fix elastic#204441 It ain't beautiful but it works. I am going to come in with another pr to deal with prefix detection holistically ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #204441
It ain't beautiful but it works. I am going to come in with another pr to deal with prefix detection holistically
Checklist