Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix hard-coded links to master #209043

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 31, 2025

Summary

Relates to elastic/docs#3160

This PR addresses the following links that will break when we stop building "master" documentation:

INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/kibana/8.11/whats-new.html contains broken links to:
--
  | INFO:build_docs:   - en/elasticsearch/reference/master/esql.html

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting docs labels Jan 31, 2025
Copy link
Contributor

Documentation preview:

@lcawl lcawl requested a review from a team January 31, 2025 03:46
@lcawl lcawl marked this pull request as ready for review January 31, 2025 03:47
@elasticmachine
Copy link
Contributor

CI was triggered for this PR, but this PR targets 8.11 which should not receive a future release. CI is not supported for these branches. Please consult the release schedule, or contact #kibana-operations if you believe this is an error.

The following branches are currently considered to be open:

  • main
  • 8.x
  • 8.18
  • 8.17
  • 8.16
  • 7.17

@lcawl lcawl added the skip-ci label Feb 4, 2025
@lcawl lcawl merged commit 5bf80dd into elastic:8.11 Feb 4, 2025
13 of 15 checks passed
@lcawl lcawl deleted the 811-fix-links branch February 4, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting docs release_note:skip Skip the PR/issue when compiling release notes skip-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants