Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Make savedQueryManagement feature explicit in Serverless #208911

Merged
merged 4 commits into from
Jan 31, 2025
+12 −58
Merged

[Security Solution] Make savedQueryManagement feature explicit in Serverless #208911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7df63f
make savedQueryManagement feature explicit
semd Jan 30, 2025
9b70b4f
update test snapshot
semd Jan 30, 2025
dfd5ae5
fix deprecated siem override
semd Jan 31, 2025
d3b2e31
add savedQueryManagement to the siem override to avoid behavior changes
semd Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions config/serverless.security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ xpack.features.overrides:
privileges: [ "all" ]
- feature: "maps_v2"
privileges: [ "all" ]
- feature: "savedQueryManagement"
privileges: [ "all" ]
# Security's `Read` feature privilege should implicitly grant `Read` access to Discover, Dashboard, Maps, and
# Visualize features. Additionally, it should implicitly grant privilege to create short URLs in Discover,
### Dashboard, and Visualize apps.
Expand All @@ -57,34 +55,36 @@ xpack.features.overrides:
privileges: [ "read" ]
- feature: "maps_v2"
privileges: [ "read" ]
- feature: "savedQueryManagement"
privileges: [ "read" ]

### Security's feature privileges are fine-tuned to grant access to Discover, Dashboard, Maps, and Visualize apps.
siem:
privileges:
### Security's `All` feature privilege should implicitly grant `All` access to Discover, Dashboard, Maps, and
### Visualize features.
all.composedOf:
- feature: "discover"
- feature: "discover_v2"
privileges: [ "all" ]
- feature: "dashboard_v2"
privileges: [ "all" ]
- feature: "dashboard"
- feature: "visualize_v2"
privileges: [ "all" ]
- feature: "visualize"
- feature: "maps_v2"
privileges: [ "all" ]
- feature: "maps"
- feature: "savedQueryManagement"
privileges: [ "all" ]
# Security's `Read` feature privilege should implicitly grant `Read` access to Discover, Dashboard, Maps, and
# Visualize features. Additionally, it should implicitly grant privilege to create short URLs in Discover,
### Dashboard, and Visualize apps.
read.composedOf:
- feature: "discover"
- feature: "discover_v2"
privileges: [ "read" ]
- feature: "dashboard_v2"
privileges: [ "read" ]
- feature: "dashboard"
- feature: "visualize_v2"
privileges: [ "read" ]
- feature: "visualize"
- feature: "maps_v2"
privileges: [ "read" ]
- feature: "maps"
- feature: "savedQueryManagement"
privileges: [ "read" ]

## Cloud settings
Expand Down
46 changes: 0 additions & 46 deletions ...k/test_serverless/api_integration/test_suites/security/platform_security/authorization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,22 +913,6 @@ export default function ({ getService }: FtrProviderContext) {
"saved_object:map/share_to_space",
"ui:maps_v2/save",
"ui:maps_v2/show",
"api:savedQuery:manage",
"api:savedQuery:read",
"saved_object:query/bulk_get",
"saved_object:query/get",
"saved_object:query/find",
"saved_object:query/open_point_in_time",
"saved_object:query/close_point_in_time",
"saved_object:query/create",
"saved_object:query/bulk_create",
"saved_object:query/update",
"saved_object:query/bulk_update",
"saved_object:query/delete",
"saved_object:query/bulk_delete",
"saved_object:query/share_to_space",
"ui:savedQueryManagement/showQueries",
"ui:savedQueryManagement/saveQuery",
],
"blocklist_all": Array [
"login:",
Expand Down Expand Up @@ -1755,22 +1739,6 @@ export default function ({ getService }: FtrProviderContext) {
"saved_object:map/share_to_space",
"ui:maps_v2/save",
"ui:maps_v2/show",
"api:savedQuery:manage",
"api:savedQuery:read",
"saved_object:query/bulk_get",
"saved_object:query/get",
"saved_object:query/find",
"saved_object:query/open_point_in_time",
"saved_object:query/close_point_in_time",
"saved_object:query/create",
"saved_object:query/bulk_create",
"saved_object:query/update",
"saved_object:query/bulk_update",
"saved_object:query/delete",
"saved_object:query/bulk_delete",
"saved_object:query/share_to_space",
"ui:savedQueryManagement/showQueries",
"ui:savedQueryManagement/saveQuery",
],
"minimal_read": Array [
"login:",
Expand Down Expand Up @@ -2096,13 +2064,6 @@ export default function ({ getService }: FtrProviderContext) {
"ui:catalogue/maps",
"ui:navLinks/maps",
"ui:maps_v2/show",
"api:savedQuery:read",
"saved_object:query/bulk_get",
"saved_object:query/get",
"saved_object:query/find",
"saved_object:query/open_point_in_time",
"saved_object:query/close_point_in_time",
"ui:savedQueryManagement/showQueries",
],
"policy_management_all": Array [
"login:",
Expand Down Expand Up @@ -2464,13 +2425,6 @@ export default function ({ getService }: FtrProviderContext) {
"ui:catalogue/maps",
"ui:navLinks/maps",
"ui:maps_v2/show",
"api:savedQuery:read",
"saved_object:query/bulk_get",
"saved_object:query/get",
"saved_object:query/find",
"saved_object:query/open_point_in_time",
"saved_object:query/close_point_in_time",
"ui:savedQueryManagement/showQueries",
],
"scan_operations_all": Array [
"login:",
Expand Down