[EDR Workflows][Staged rollout] Add artifact channel to Alert flyout's highlighted fields #208346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergoabraham
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
PhilippeOberti
approved these changes
Jan 27, 2025
dhurley14
approved these changes
Jan 28, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
…s highlighted fields (elastic#208346) ## Summary This PR adds `Endpoint.policy.applied.artifacts.global.channel` to the highlighted fields of an alert. This field shows the users, which artifact channel was used to update the rules on an Endpoint using Elastic Defend integration. Based on the structure of the highlighted fields, I think it makes sense to add it to the 'always displayed fields', but not 100% sure on it, so I'm happy to take suggestions. <img width="731" alt="image" src="https://github.com/user-attachments/assets/952dfc92-e9c4-4b38-8fba-8fc6a5e07ed8" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 82d94f1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
…lyout's highlighted fields (#208346) (#208567) # Backport This will backport the following commits from `main` to `8.x`: - [[EDR Workflows][Staged rollout] Add artifact channel to Alert flyout's highlighted fields (#208346)](#208346) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T16:10:10Z","message":"[EDR Workflows][Staged rollout] Add artifact channel to Alert flyout's highlighted fields (#208346)\n\n## Summary\r\n\r\nThis PR adds `Endpoint.policy.applied.artifacts.global.channel` to the\r\nhighlighted fields of an alert. This field shows the users, which\r\nartifact channel was used to update the rules on an Endpoint using\r\nElastic Defend integration.\r\n\r\nBased on the structure of the highlighted fields, I think it makes sense\r\nto add it to the 'always displayed fields', but not 100% sure on it, so\r\nI'm happy to take suggestions.\r\n\r\n<img width=\"731\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/952dfc92-e9c4-4b38-8fba-8fc6a5e07ed8\"\r\n/>\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"82d94f17c91f8dcd93563dbbb47fba9f13c56d3a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","backport:prev-minor"],"title":"[EDR Workflows][Staged rollout] Add artifact channel to Alert flyout's highlighted fields","number":208346,"url":"https://github.com/elastic/kibana/pull/208346","mergeCommit":{"message":"[EDR Workflows][Staged rollout] Add artifact channel to Alert flyout's highlighted fields (#208346)\n\n## Summary\r\n\r\nThis PR adds `Endpoint.policy.applied.artifacts.global.channel` to the\r\nhighlighted fields of an alert. This field shows the users, which\r\nartifact channel was used to update the rules on an Endpoint using\r\nElastic Defend integration.\r\n\r\nBased on the structure of the highlighted fields, I think it makes sense\r\nto add it to the 'always displayed fields', but not 100% sure on it, so\r\nI'm happy to take suggestions.\r\n\r\n<img width=\"731\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/952dfc92-e9c4-4b38-8fba-8fc6a5e07ed8\"\r\n/>\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"82d94f17c91f8dcd93563dbbb47fba9f13c56d3a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208346","number":208346,"mergeCommit":{"message":"[EDR Workflows][Staged rollout] Add artifact channel to Alert flyout's highlighted fields (#208346)\n\n## Summary\r\n\r\nThis PR adds `Endpoint.policy.applied.artifacts.global.channel` to the\r\nhighlighted fields of an alert. This field shows the users, which\r\nartifact channel was used to update the rules on an Endpoint using\r\nElastic Defend integration.\r\n\r\nBased on the structure of the highlighted fields, I think it makes sense\r\nto add it to the 'always displayed fields', but not 100% sure on it, so\r\nI'm happy to take suggestions.\r\n\r\n<img width=\"731\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/952dfc92-e9c4-4b38-8fba-8fc6a5e07ed8\"\r\n/>\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"82d94f17c91f8dcd93563dbbb47fba9f13c56d3a"}}]}] BACKPORT--> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
Endpoint.policy.applied.artifacts.global.channelto the highlighted fields of an alert. This field shows the users, which artifact channel was used to update the rules on an Endpoint using Elastic Defend integration.Based on the structure of the highlighted fields, I think it makes sense to add it to the 'always displayed fields', but not 100% sure on it, so I'm happy to take suggestions.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.