[ Security Solution ] - Better row indicators with getRowIndicator callback
#206736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
added
Team:Threat Hunting:Investigations
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
janmonschke
reviewed
Jan 15, 2025
...ons/security/plugins/security_solution/public/timelines/components/timeline/body/helpers.tsx
Outdated
Show resolved
Hide resolved
janmonschke
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Adding even more logic to those styled components we're trying to get rid off 😆
This one won't be fun to convert to @emtion/react! Problem for future us though...
There was a problem hiding this comment.
Yes, it is too loaded a component and i have been looking for an opportunity to break it down. But i agree, this PR is not right for it..
|
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 21, 2025
…callback (elastic#206736) ## Summary Recently unified table introduced `getRowIndicator` callback to add row highlighting. Today Security solution achieves that by using `border-left` style. This PR replaces that `border-left` with `getRowIndicator` . > [!Note] > One thing to note is that `Event/Row Renderers` will still make use of `border-left` as it is a cell and `getRowIndicator` applies only to a complete `row`. ### Without Row Renderers || Before | After | |---|---|---| |Query Tab |  | | |Correlation Tab| || ### With Row Renderers || Before | After | |---|---|---| |Query Tab | || |Correlation Tab||| ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 3d37119)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 21, 2025
…callback (elastic#206736) ## Summary Recently unified table introduced `getRowIndicator` callback to add row highlighting. Today Security solution achieves that by using `border-left` style. This PR replaces that `border-left` with `getRowIndicator` . > [!Note] > One thing to note is that `Event/Row Renderers` will still make use of `border-left` as it is a cell and `getRowIndicator` applies only to a complete `row`. ### Without Row Renderers || Before | After | |---|---|---| |Query Tab |  | | |Correlation Tab| || ### With Row Renderers || Before | After | |---|---|---| |Query Tab | || |Correlation Tab||| ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
added a commit
that referenced
this pull request
Jan 21, 2025
…Indicator` callback (#206736) (#207387) # Backport This will backport the following commits from `main` to `8.x`: - [[ Security Solution ] - Better row indicators with `getRowIndicator` callback (#206736)](#206736) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2025-01-21T15:28:55Z","message":"[ Security Solution ] - Better row indicators with `getRowIndicator` callback (#206736)\n\n## Summary\n\nRecently unified table introduced `getRowIndicator` callback to add row\nhighlighting. Today Security solution achieves that by using\n`border-left` style.\n\nThis PR replaces that `border-left` with `getRowIndicator` . \n\n> [!Note]\n> One thing to note is that `Event/Row Renderers` will still make use of\n`border-left` as it is a cell and `getRowIndicator` applies only to a\ncomplete `row`.\n\n### Without Row Renderers\n\n|| Before | After |\n|---|---|---|\n|Query Tab |\n\n|\n|\n|Correlation Tab|\n||\n\n### With Row Renderers\n\n|| Before | After |\n|---|---|---|\n|Query Tab |\n||\n|Correlation\nTab|||\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"3d37119ce7a7f05c7f60995db176293daab0d043","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:prev-minor","backport:version"],"title":"[ Security Solution ] - Better row indicators with `getRowIndicator` callback","number":206736,"url":"https://github.com/elastic/kibana/pull/206736","mergeCommit":{"message":"[ Security Solution ] - Better row indicators with `getRowIndicator` callback (#206736)\n\n## Summary\n\nRecently unified table introduced `getRowIndicator` callback to add row\nhighlighting. Today Security solution achieves that by using\n`border-left` style.\n\nThis PR replaces that `border-left` with `getRowIndicator` . \n\n> [!Note]\n> One thing to note is that `Event/Row Renderers` will still make use of\n`border-left` as it is a cell and `getRowIndicator` applies only to a\ncomplete `row`.\n\n### Without Row Renderers\n\n|| Before | After |\n|---|---|---|\n|Query Tab |\n\n|\n|\n|Correlation Tab|\n||\n\n### With Row Renderers\n\n|| Before | After |\n|---|---|---|\n|Query Tab |\n||\n|Correlation\nTab|||\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"3d37119ce7a7f05c7f60995db176293daab0d043"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206736","number":206736,"mergeCommit":{"message":"[ Security Solution ] - Better row indicators with `getRowIndicator` callback (#206736)\n\n## Summary\n\nRecently unified table introduced `getRowIndicator` callback to add row\nhighlighting. Today Security solution achieves that by using\n`border-left` style.\n\nThis PR replaces that `border-left` with `getRowIndicator` . \n\n> [!Note]\n> One thing to note is that `Event/Row Renderers` will still make use of\n`border-left` as it is a cell and `getRowIndicator` applies only to a\ncomplete `row`.\n\n### Without Row Renderers\n\n|| Before | After |\n|---|---|---|\n|Query Tab |\n\n|\n|\n|Correlation Tab|\n||\n\n### With Row Renderers\n\n|| Before | After |\n|---|---|---|\n|Query Tab |\n||\n|Correlation\nTab|||\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"3d37119ce7a7f05c7f60995db176293daab0d043"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…callback (elastic#206736) ## Summary Recently unified table introduced `getRowIndicator` callback to add row highlighting. Today Security solution achieves that by using `border-left` style. This PR replaces that `border-left` with `getRowIndicator` . > [!Note] > One thing to note is that `Event/Row Renderers` will still make use of `border-left` as it is a cell and `getRowIndicator` applies only to a complete `row`. ### Without Row Renderers || Before | After | |---|---|---| |Query Tab |  | | |Correlation Tab| || ### With Row Renderers || Before | After | |---|---|---| |Query Tab | || |Correlation Tab||| ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently unified table introduced
getRowIndicatorcallback to add row highlighting. Today Security solution achieves that by usingborder-leftstyle.This PR replaces that
border-leftwithgetRowIndicator.Note
One thing to note is that
Event/Row Rendererswill still make use ofborder-leftas it is a cell andgetRowIndicatorapplies only to a completerow.Without Row Renderers
With Row Renderers
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.