Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(slo): update telemetry data #206135

Merged
merged 8 commits into from
Jan 14, 2025
Merged

chore(slo): update telemetry data #206135

merged 8 commits into from
Jan 14, 2025

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Jan 9, 2025 •
edited by kibanamachine
Loading

Resolves #206096

Summary

Update SLO telemetry data to include the breakdown of total SLO definitions using CCS or defined with groupings, as well as the total number of SLO instances.

I've also udpated the test to use real es/kibana instances.

You can verify the telemetry is sent correctly by going to the Stack Management > Advanced Settings > Global > Usage Collector

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.18.0 backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 10, 2025
@kdelemme kdelemme marked this pull request as ready for review January 10, 2025 19:18
@kdelemme kdelemme requested a review from a team as a code owner January 10, 2025 19:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner January 10, 2025 21:22
afharo
afharo approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM

afharo
afharo approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM

dominiqueclarke
dominiqueclarke approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a reminder to update the test name.

.../solutions/observability/plugins/slo/server/lib/collectors/integration_tests/fetcher.test.ts Outdated
await stopServers();
});

describe('soomething', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
describe('soomething', () => {
describe('something else', () => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes completely forgot to update those

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #6 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Bootstrap Prebuilt Rules should install fleet packages required for detection engine to function

Metrics [docs]

✅ unchanged

History

@kdelemme kdelemme merged commit 9618e42 into elastic:main Jan 14, 2025
8 checks passed
@kdelemme kdelemme deleted the chore/slo-telemetry-update branch January 14, 2025 18:29
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12774070640

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 206135

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 15, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 206135 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 206135 locally

@kdelemme kdelemme mentioned this pull request Jan 17, 2025
Merged
@kdelemme
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kdelemme added a commit to kdelemme/kibana that referenced this pull request Jan 17, 2025
@kdelemme
chore(slo): update telemetry data (elastic#206135)
319950e 
(cherry picked from commit 9618e42)

# Conflicts:
#	x-pack/solutions/observability/plugins/slo/tsconfig.json
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine mentioned this pull request Jan 20, 2025
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kdelemme added a commit that referenced this pull request Jan 21, 2025
@kdelemme
[8.x] chore(slo): update telemetry data (#206135) (#207101)
8418be4 
# Backport

This will backport the following commits from `main` to `8.x`:
- [chore(slo): update telemetry data
(#206135)](#206135)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2025-01-14T18:29:25Z","message":"chore(slo):
update telemetry data
(#206135)","sha":"9618e4254894e2fcf73572edaab417f54845fe7b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-minor","Team:obs-ux-management","v8.18.0"],"title":"chore(slo):
update telemetry
data","number":206135,"url":"https://github.com/elastic/kibana/pull/206135","mergeCommit":{"message":"chore(slo):
update telemetry data
(#206135)","sha":"9618e4254894e2fcf73572edaab417f54845fe7b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206135","number":206135,"mergeCommit":{"message":"chore(slo):
update telemetry data
(#206135)","sha":"9618e4254894e2fcf73572edaab417f54845fe7b"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 21, 2025
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@kdelemme @viduni94
chore(slo): update telemetry data (elastic#206135)
a6bd26e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLO] Add telemetry for CCS vs local defined SLO
5 participants
@kdelemme @elasticmachine @kibanamachine @afharo @dominiqueclarke