Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens][Security Solutions] Restore cypress tests #206025

Merged
merged 2 commits into from
Jan 10, 2025
Merged

[Lens][Security Solutions] Restore cypress tests #206025

merged 2 commits into from
Jan 10, 2025

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jan 9, 2025 •
edited by kibanamachine
Loading

Summary

Fixes #198756

Checklist

@dej611
Copy link
Contributor Author

dej611 commented Jan 9, 2025

/ci

@dej611 dej611 added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 9, 2025
@dej611 dej611 marked this pull request as ready for review January 9, 2025 12:43
@dej611 dej611 requested a review from a team as a code owner January 9, 2025 12:43
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

janmonschke
janmonschke approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know which code change made these tests work on CI?

@dej611
Copy link
Contributor Author

dej611 commented Jan 10, 2025

Do you know which code change made these tests work on CI?

Didn't track it specifically, but given the reload problem for one of the test, there's a high probability this is the fix PR: #203150

@dej611 dej611 merged commit 6e3c967 into elastic:main Jan 10, 2025
14 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12707200930

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 10, 2025
@dej611
[Lens][Security Solutions] Restore cypress tests (elastic#206025)
b782927 
## Summary

Fixes elastic#198756

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 6e3c967)
@kibanamachine kibanamachine mentioned this pull request Jan 10, 2025
Open
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 13, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@dej611 @CAWilson94
[Lens][Security Solutions] Restore cypress tests (elastic#206025)
2965c43 
## Summary

Fixes elastic#198756 


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@kibanamachine kibanamachine mentioned this pull request Jan 13, 2025
Merged
1 task
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

5 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@dej611 dej611 added the backport:skip This commit does not require backporting label Jan 21, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 21, 2025
@dej611 dej611 removed the backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) label Jan 21, 2025
@dej611 dej611 added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 21, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 21, 2025
@dej611
Copy link
Contributor Author

dej611 commented Jan 21, 2025

Skipping as another PR got backported with it already.

viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@dej611 @viduni94
[Lens][Security Solutions] Restore cypress tests (elastic#206025)
6226686 
## Summary

Fixes elastic#198756 


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmonschke janmonschke janmonschke approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens][Security][Embeddable refactor followup] Unskip cypress test
4 participants
@dej611 @elasticmachine @kibanamachine @janmonschke