Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Memory Usage and Notifications pages serverless functional tests #205898

Merged
merged 8 commits into from
Jan 17, 2025
Merged

[ML] Memory Usage and Notifications pages serverless functional tests #205898

merged 8 commits into from
Jan 17, 2025

Conversation

rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Jan 8, 2025 •
edited by kibanamachine
Loading

Part of: #201813

  • Memory Usage. Check ML entities are filtered according to the project type.

  • Notifications page. Check ML entities are filtered according to the project type.

@rbrtj rbrtj changed the title Ml memory usage and notifications serverless tests [ML] Memory Usage and Notifications pages serverless functional tests Jan 8, 2025
@rbrtj rbrtj self-assigned this Jan 8, 2025
@rbrtj rbrtj added :ml release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:ML Team label for ML (also use :ml) backport:version Backport to applied version labels v8.18.0 labels Jan 8, 2025
@rbrtj rbrtj marked this pull request as ready for review January 8, 2025 14:39
@rbrtj rbrtj requested review from a team as code owners January 8, 2025 14:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@rbrtj rbrtj requested a review from jgowdyelastic January 8, 2025 16:42
peteharverson
peteharverson reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just made some suggestion to clarify some of the text and variable names.

x-pack/test_serverless/functional/test_suites/security/ml/memory_usage.ts Outdated
const svlMl = getService('svlMl');
const PageObjects = getPageObjects(['svlCommonPage']);

const availableSecurityIndicies = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, for clarity I'd suggest renaming this to something like availableMLObjectTypes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 85f969f

@peteharverson peteharverson mentioned this pull request Jan 8, 2025
Closed
11 tasks
@rbrtj rbrtj requested a review from peteharverson January 14, 2025 10:32
peteharverson
peteharverson approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making those text changes.

jgowdyelastic
jgowdyelastic approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @rbrtj

@rbrtj rbrtj merged commit 9bc2438 into elastic:main Jan 17, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12828101896

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 17, 2025
@rbrtj
[ML] Memory Usage and Notifications pages serverless functional tests (…
cf517ae 
…elastic#205898)

Part of: elastic#201813

- [x] Memory Usage. Check ML entities are filtered according to the
project type.

- [x] Notifications page. Check ML entities are filtered according to
the project type.

(cherry picked from commit 9bc2438)
@kibanamachine kibanamachine mentioned this pull request Jan 17, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 17, 2025
@kibanamachine @rbrtj
[8.x] [ML] Memory Usage and Notifications pages serverless functional…
7c039e1 
… tests (#205898) (#207055)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Memory Usage and Notifications pages serverless functional tests
(#205898)](#205898)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-17T11:22:34Z","message":"[ML]
Memory Usage and Notifications pages serverless functional tests
(#205898)\n\nPart of:
https://github.com/elastic/kibana/issues/201813\n\n- [x] Memory Usage.
Check ML entities are filtered according to the\nproject type.\n\n- [x]
Notifications page. Check ML entities are filtered according to\nthe
project
type.","sha":"9bc2438eed4f2f099ebbca597a2327f5c5aff4ed","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Team:ML","backport:version","v8.18.0"],"title":"[ML]
Memory Usage and Notifications pages serverless functional
tests","number":205898,"url":"https://github.com/elastic/kibana/pull/205898","mergeCommit":{"message":"[ML]
Memory Usage and Notifications pages serverless functional tests
(#205898)\n\nPart of:
https://github.com/elastic/kibana/issues/201813\n\n- [x] Memory Usage.
Check ML entities are filtered according to the\nproject type.\n\n- [x]
Notifications page. Check ML entities are filtered according to\nthe
project
type.","sha":"9bc2438eed4f2f099ebbca597a2327f5c5aff4ed"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205898","number":205898,"mergeCommit":{"message":"[ML]
Memory Usage and Notifications pages serverless functional tests
(#205898)\n\nPart of:
https://github.com/elastic/kibana/issues/201813\n\n- [x] Memory Usage.
Check ML entities are filtered according to the\nproject type.\n\n- [x]
Notifications page. Check ML entities are filtered according to\nthe
project
type.","sha":"9bc2438eed4f2f099ebbca597a2327f5c5aff4ed"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 17, 2025
@rbrtj @cqliu1
[ML] Memory Usage and Notifications pages serverless functional tests (…
15f09f5 
…elastic#205898)

Part of: elastic#201813

- [x] Memory Usage. Check ML entities are filtered according to the
project type.

- [x] Notifications page. Check ML entities are filtered according to
the project type.
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 21, 2025
@rbrtj @cqliu1
[ML] Memory Usage and Notifications pages serverless functional tests (…
08b88e6 
…elastic#205898)

Part of: elastic#201813

- [x] Memory Usage. Check ML entities are filtered according to the
project type.

- [x] Notifications page. Check ML entities are filtered according to
the project type.
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@rbrtj @viduni94
[ML] Memory Usage and Notifications pages serverless functional tests (…
ba4649f 
…elastic#205898)

Part of: elastic#201813

- [x] Memory Usage. Check ML entities are filtered according to the
project type.

- [x] Notifications page. Check ML entities are filtered according to
the project type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wayneseymour wayneseymour wayneseymour approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@rbrtj rbrtj

Labels
backport:version Backport to applied version labels :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rbrtj @elasticmachine @kibanamachine @wayneseymour @peteharverson @jgowdyelastic