[ML] Transforms: Improve messages for recovered alerts #205721
Conversation
darnautov
added
:ml
Feature:Transforms
|
Pinging @elastic/ml-ui (:ml) |
walterra
changed the title
| const count = response.length; | ||
| const transformsString = response.map((t) => t.transform_id).join(', '); | ||
| const count: number = isHealthy ? previousState?.unhealthy?.length ?? 0 : response.length; | ||
| const transformsString = isHealthy |
There was a problem hiding this comment.
As discussed, what about limiting the number of IDs we display in the first part of the message to say 10 (?), to say something like
35 transforms are not started: endpoint.metadata_current-default-8.18.0-prerelease.1, endpoint.metadata_united-default-8.18.0-prerelease.1, fq_continuous_latest_transform, fq_response_times_continuous, gallery_latest_transform, transform_a, transform_b, transform_c, transform_d, transform_e and 25 others
If a user really wants to see all the IDs they can loop through each of the IDs usinh the context variables.
There was a problem hiding this comment.
Updated in f36309a
...nsform/server/lib/alerting/transform_health_rule_type/register_transform_health_rule_type.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Latest text change for the format of the alert message to list only the first 10 IDs with an e.g. and 10 others LGTM.
One question - if there were e.g. 6 unhealthy transforms, and then 5 become healthy, followed some time later by the 6th transform becoming healthy, then you only get a recovered message when the final transform becomes healthy. The recovered message only includes the ID(s) of the transforms which become healthy in the current check. You don't get any indication that the first 5 transforms have become healthy. Guess this is a limitation of the framework and you only get the ID(s) of the last transform to become healthy when it goes to recovered?
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
cc @darnautov |
|
Starting backport for target branches: 8.x |
(cherry picked from commit 737cf96)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
#206110) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Transforms: Improve messages for recovered alerts (#205721)](#205721) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2025-01-09T16:53:09Z","message":"[ML] Transforms: Improve messages for recovered alerts (#205721)","sha":"737cf968094c464a8824933c0f5017fd1b511e71","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:Transforms","v9.0.0","Feature:Alerting/RuleTypes","Team:ML","backport:version","v8.18.0"],"title":"[ML] Transforms: Improve messages for recovered alerts ","number":205721,"url":"https://github.com/elastic/kibana/pull/205721","mergeCommit":{"message":"[ML] Transforms: Improve messages for recovered alerts (#205721)","sha":"737cf968094c464a8824933c0f5017fd1b511e71"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205721","number":205721,"mergeCommit":{"message":"[ML] Transforms: Improve messages for recovered alerts (#205721)","sha":"737cf968094c464a8824933c0f5017fd1b511e71"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Summary
Updates the transform health alerting rules:
Checklist