Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Upgrade EUI to v98.2.1-borealis.1 #204783

Merged
merged 4 commits into from
Jan 8, 2025
Merged

[8.x] Upgrade EUI to v98.2.1-borealis.1 #204783

merged 4 commits into from
Jan 8, 2025

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Dec 18, 2024 •
edited
Loading

Important

This PR introduces the Borealis enabled EUI package to 8.x.
The intention is to support new features being developed that need to live in main as well as 8.x.

Important

All 8.x versions should continue to use the current Amsterdam theme. To ensure this even with upcoming changes to the default theme for EUI, we're adding euiThemeAmsterdam on EuiProvider usages manually.

Description

This PR introduces all previous Borealis related PR changes but excludes the specific changes to support @elastic/eui-theme-borealis as only Amsterdam is supported as theme in 8.x.

Previous PRs

v97.3.1⏩v98.2.1-borealis.1

Questions? Please see our Kibana upgrade FAQ.

@elastic/eui

v98.2.1

  • Updated the EUI theme color values to use a full 6 char hex code format (#8244)

v98.2.0

  • Added two new icons: contrast and contrastHigh (#8216)
  • Updated EuiDataGrid content to have a transparent background. (#8220)

Accessibility

  • When the tooltips components (EuiTooltip, EuiIconTip) are used inside components that handle the Escape key (like EuiFlyout or EuiModal), pressing the Escape key will now only close the tooltip and not the entire wrapping component. (#8140)
  • Improved the accessibility of EuiCodeBlocks by (#8195)
    • adding screen reader only labels
    • adding role="dialog" on in fullscreen mode
    • ensuring focus is returned on closing fullscreen mode

Borealis updates

  • [Visual Refresh] Update color token mappings (#8211)
  • [Visual Refresh] Introduce shared popover arrow styles to Borealis (#8212)
  • [Visual Refresh] Add forms.maxWidth token (#8221)
  • [Visual Refresh] Set darker shade for subdued text (#8224)
  • [Visual Refresh] Remove support for accentSecondary badges (#8224)
  • [Visual Refresh] Add severity vis colors (#8247)

@elastic/eui

v98.1.0

  • Updated EuiBetaBadge with a new warning color variant (#8177)

Accessibility

  • Ensures autoFocus on EuiSelectableList triggers initial focus (#8091)
  • Improved the accessibility of EuiSearchBarFilters by: (#8091)
    • adding a more descriptive aria-label to selection filter buttons
    • ensuring the selection listbox is initially focused when opening a selection popover
  • Improved the accessibility experience of tabs (EuiTab, EuiTabs): tab group is a tab stop and tabs can be traversed with arrow keys. (#8116)
  • Updated EuiCodeBlock with a new copyAriaLabel prop, which allows setting a custom screen reader label on the copy button. (#8176)

CSS-in-JS conversions

  • Removed the following global Sass variables: (#8169)
    • $euiButtonMinWidth
    • $euiDatePickerCalendarWidth
  • Removed the following Sass animations: (#8169)
    • euiAnimFadeIn
    • euiGrow
    • focusRingAnimate
    • focusRingAnimateLarge
    • euiButtonActive
  • Removed the following Sass mixins: (#8169)
    • euiFullHeight
    • euiSlightShadowHover
    • datePickerArrow

Borealis updates

@elastic/eui

v98.0.0

Bug fixes

  • Fixed an EuiDataGrid bug where column actions where not clickable when EuiDataGrid with columnVisibility.canDragAndDropColumns was used inside a modal (#8135)

Breaking changes

  • Removed EuiFormRow's deprecated columnCompressedSwitch display prop. Use columnCompressed instead (#8113)

Borealis updates

Bug fixes

@mgadewoll mgadewoll added release_note:skip Skip the PR/issue when compiling release notes EUI EUI Visual Refresh backport:skip This commit does not require backporting labels Dec 18, 2024
@mgadewoll mgadewoll changed the title [8.x] Upgrade EUI to 98.2.1-borealis.1 [8.x] Upgrade EUI to v98.2.1-borealis.1 Dec 18, 2024
@mgadewoll mgadewoll force-pushed the eui/v98.2.1-borealis.1-8.x branch from 20ed9bf to 1f95556 Compare December 19, 2024 09:14
@mgadewoll mgadewoll marked this pull request as ready for review December 19, 2024 11:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@tkajtoch tkajtoch marked this pull request as draft December 19, 2024 12:40
@tkajtoch tkajtoch assigned tkajtoch and unassigned tkajtoch Dec 19, 2024
@tkajtoch tkajtoch marked this pull request as ready for review December 19, 2024 12:40
@JasonStoltz JasonStoltz requested review from a team, dhurley14 and pzl and removed request for a team December 19, 2024 13:04
MiriamAparicio
MiriamAparicio approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for obs-ux-infra_services-team LGTM

@Dosant Dosant mentioned this pull request Dec 20, 2024
Open
rylnd
rylnd approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no changes to @elastic/security-detection-engine here, but I checked out this branch to verify that the workflows for our our areas continued to work/look correct on the Amsterdam theme.

SoniaSanzV
SoniaSanzV approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana Management changes (extend_index_management snapshot) LGTM

@mgadewoll mgadewoll force-pushed the eui/v98.2.1-borealis.1-8.x branch 2 times, most recently from f095176 to b3952a1 Compare January 6, 2025 14:35
@mgadewoll
Copy link
Contributor Author

@elastic/security-defend-workflows Would you be able to have a look too?

eokoneyo
eokoneyo approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared UX changes LGTM

@mgadewoll mgadewoll force-pushed the eui/v98.2.1-borealis.1-8.x branch from b3952a1 to 244afc9 Compare January 7, 2025 14:33
@mgadewoll mgadewoll enabled auto-merge (squash) January 7, 2025 14:39
@mgadewoll mgadewoll disabled auto-merge January 7, 2025 22:42
@mgadewoll mgadewoll force-pushed the eui/v98.2.1-borealis.1-8.x branch from 6e74612 to 94d45d0 Compare January 8, 2025 08:19
@mgadewoll mgadewoll enabled auto-merge (squash) January 8, 2025 08:19
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 8, 2025 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 94d45d0
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204783-94d45d01d217

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
controls 353 357 +4
dashboard 670 675 +5
infra 1519 1528 +9
kubernetesSecurity 194 203 +9
maps 1244 1249 +5
ml 2116 2125 +9
visTypeVega 268 277 +9
total +50

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +2.0B
controls 458.0KB 492.7KB +34.6KB
core 60.9KB 60.9KB +1.0B
dashboard 631.0KB 666.4KB +35.5KB
fileUpload 951.4KB 951.4KB -1.0B
infra 1.7MB 1.8MB +42.8KB
ingestPipelines 406.4KB 406.4KB +1.0B
kibanaReact 197.1KB 197.1KB +1.0B
kibanaUtils 60.8KB 60.8KB +1.0B
kubernetesSecurity 214.6KB 257.9KB +43.3KB
maps 3.0MB 3.0MB +35.5KB
ml 4.6MB 4.7MB +42.8KB
observabilityAIAssistantApp 296.3KB 296.4KB +19.0B
security 541.6KB 541.6KB +1.0B
securitySolution 19.2MB 19.2MB +4.0B
visTypeTimeseries 507.7KB 507.7KB +1.0B
visTypeVega 1.9MB 1.9MB +42.8KB
total +277.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 448.2KB 448.6KB +421.0B
kbnUiSharedDeps-npmDll 5.8MB 5.9MB +63.9KB
kbnUiSharedDeps-srcJs 3.5MB 3.5MB +26.0B
total +64.3KB

History

cc @mgadewoll

@mgadewoll mgadewoll merged commit 1384ced into elastic:8.x Jan 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonStoltz JasonStoltz JasonStoltz left review comments

@Dosant Dosant Dosant left review comments

@Heenawter Heenawter Heenawter approved these changes

@eokoneyo eokoneyo eokoneyo approved these changes

@viduni94 viduni94 viduni94 approved these changes

@afharo afharo afharo approved these changes

@SoniaSanzV SoniaSanzV SoniaSanzV approved these changes

@gergoabraham gergoabraham gergoabraham approved these changes

@markov00 markov00 markov00 approved these changes

@pzl pzl pzl approved these changes

@elena-shostak elena-shostak elena-shostak approved these changes

@stratoula stratoula stratoula approved these changes

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@consulthys consulthys consulthys approved these changes

@mistic mistic mistic approved these changes

@jughosta jughosta jughosta approved these changes

@rylnd rylnd rylnd approved these changes

@fkanout fkanout fkanout approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

@dhurley14 dhurley14 Awaiting requested review from dhurley14 dhurley14 was automatically assigned from elastic/security-detection-engine

Assignees

@mgadewoll mgadewoll

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project EUI Visual Refresh EUI release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.