[ML] Transforms: Support wildcards in the alerting rule flyout #204226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
:ml
Feature:Transforms
|
Pinging @elastic/ml-ui (:ml) |
rbrtj
approved these changes
Dec 17, 2024
| ? (((searchValue, existingOptions) => { | ||
| if ( | ||
| searchValue.includes('*') && | ||
| !existingOptions.some((option) => option.label === searchValue) |
There was a problem hiding this comment.
Do we need this additional check? It seems to already be derived from allowCustomOptions
There was a problem hiding this comment.
It's indeed redundant, had added this check before introducing the allowCustomOptions. Removed in c250dc4.
11 tasks
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.17, 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @darnautov |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2024
…ic#204226) ## Summary Closes elastic#166810 - Adds wildcards support for the tranform health alerting rule. - Populates transforms with alerting rules based on wildcard expressions. - Excludes `alerting_rules` from the JSON tab. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit fd98643)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 17, 2024
…204226) (#204575) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Transforms: Support wildcards in the alerting rule flyout (#204226)](#204226) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2024-12-17T13:28:39Z","message":"[ML] Transforms: Support wildcards in the alerting rule flyout (#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds wildcards support for the tranform health alerting rule. \r\n- Populates transforms with alerting rules based on wildcard\r\nexpressions.\r\n- Excludes `alerting_rules` from the JSON tab. \r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:Transforms","v9.0.0","Team:ML","backport:version","v8.18.0","v8.17.1"],"title":"[ML] Transforms: Support wildcards in the alerting rule flyout","number":204226,"url":"https://github.com/elastic/kibana/pull/204226","mergeCommit":{"message":"[ML] Transforms: Support wildcards in the alerting rule flyout (#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds wildcards support for the tranform health alerting rule. \r\n- Populates transforms with alerting rules based on wildcard\r\nexpressions.\r\n- Excludes `alerting_rules` from the JSON tab. \r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204226","number":204226,"mergeCommit":{"message":"[ML] Transforms: Support wildcards in the alerting rule flyout (#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds wildcards support for the tranform health alerting rule. \r\n- Populates transforms with alerting rules based on wildcard\r\nexpressions.\r\n- Excludes `alerting_rules` from the JSON tab. \r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Dec 18, 2024
…ic#204226) ## Summary Closes elastic#166810 - Adds wildcards support for the tranform health alerting rule. - Populates transforms with alerting rules based on wildcard expressions. - Excludes `alerting_rules` from the JSON tab. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit fd98643) # Conflicts: # x-pack/plugins/transform/public/alerting/transform_health_rule_type/transform_selector_control.test.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
darnautov
added a commit
that referenced
this pull request
Dec 18, 2024
…#204226) (#204713) # Backport This will backport the following commits from `main` to `8.17`: - [[ML] Transforms: Support wildcards in the alerting rule flyout (#204226)](#204226) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2024-12-17T13:28:39Z","message":"[ML] Transforms: Support wildcards in the alerting rule flyout (#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds wildcards support for the tranform health alerting rule. \r\n- Populates transforms with alerting rules based on wildcard\r\nexpressions.\r\n- Excludes `alerting_rules` from the JSON tab. \r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:Transforms","v9.0.0","Team:ML","backport:version","v8.18.0","v8.17.1"],"number":204226,"url":"https://github.com/elastic/kibana/pull/204226","mergeCommit":{"message":"[ML] Transforms: Support wildcards in the alerting rule flyout (#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds wildcards support for the tranform health alerting rule. \r\n- Populates transforms with alerting rules based on wildcard\r\nexpressions.\r\n- Excludes `alerting_rules` from the JSON tab. \r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204226","number":204226,"mergeCommit":{"message":"[ML] Transforms: Support wildcards in the alerting rule flyout (#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds wildcards support for the tranform health alerting rule. \r\n- Populates transforms with alerting rules based on wildcard\r\nexpressions.\r\n- Excludes `alerting_rules` from the JSON tab. \r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/204575","number":204575,"state":"MERGED","mergeCommit":{"sha":"dff3cc2943ec1ea9981dab84326a6e948456cd07","message":"[8.x] [ML] Transforms: Support wildcards in the alerting rule flyout (#204226) (#204575)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[ML] Transforms: Support wildcards in the alerting rule flyout\n(#204226)](https://github.com/elastic/kibana/pull/204226)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Dima\nArnautov\",\"email\":\"dmitrii.arnautov@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2024-12-17T13:28:39Z\",\"message\":\"[ML]\nTransforms: Support wildcards in the alerting rule flyout\n(#204226)\\n\\n## Summary\\r\\n\\r\\n\\r\\nCloses #166810\\r\\n\\r\\n- Adds\nwildcards support for the tranform health alerting rule. \\r\\n- Populates\ntransforms with alerting rules based on wildcard\\r\\nexpressions.\\r\\n-\nExcludes `alerting_rules` from the JSON tab. \\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] Any text added follows [EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence case text and includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n-\n[\n]\\r\\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\\r\\nwas\nadded for features that require explanation or tutorials\\r\\n- [x] [Unit\nor\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"fd986432e896d4804ede18024ce1202c6ef77d6d\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:enhancement\",\":ml\",\"Feature:Transforms\",\"v9.0.0\",\"Team:ML\",\"backport:version\",\"v8.18.0\",\"v8.17.1\"],\"title\":\"[ML]\nTransforms: Support wildcards in the alerting rule\nflyout\",\"number\":204226,\"url\":\"https://github.com/elastic/kibana/pull/204226\",\"mergeCommit\":{\"message\":\"[ML]\nTransforms: Support wildcards in the alerting rule flyout\n(#204226)\\n\\n## Summary\\r\\n\\r\\n\\r\\nCloses #166810\\r\\n\\r\\n- Adds\nwildcards support for the tranform health alerting rule. \\r\\n- Populates\ntransforms with alerting rules based on wildcard\\r\\nexpressions.\\r\\n-\nExcludes `alerting_rules` from the JSON tab. \\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] Any text added follows [EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence case text and includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n-\n[\n]\\r\\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\\r\\nwas\nadded for features that require explanation or tutorials\\r\\n- [x] [Unit\nor\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"fd986432e896d4804ede18024ce1202c6ef77d6d\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\",\"8.17\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/204226\",\"number\":204226,\"mergeCommit\":{\"message\":\"[ML]\nTransforms: Support wildcards in the alerting rule flyout\n(#204226)\\n\\n## Summary\\r\\n\\r\\n\\r\\nCloses #166810\\r\\n\\r\\n- Adds\nwildcards support for the tranform health alerting rule. \\r\\n- Populates\ntransforms with alerting rules based on wildcard\\r\\nexpressions.\\r\\n-\nExcludes `alerting_rules` from the JSON tab. \\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] Any text added follows [EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence case text and includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n-\n[\n]\\r\\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\\r\\nwas\nadded for features that require explanation or tutorials\\r\\n- [x] [Unit\nor\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"fd986432e896d4804ede18024ce1202c6ef77d6d\"}},{\"branch\":\"8.x\",\"label\":\"v8.18.0\",\"branchLabelMappingKey\":\"^v8.18.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.17\",\"label\":\"v8.17.1\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>"}},{"branch":"8.17","label":"v8.17.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…ic#204226) ## Summary Closes elastic#166810 - Adds wildcards support for the tranform health alerting rule. - Populates transforms with alerting rules based on wildcard expressions. - Excludes `alerting_rules` from the JSON tab. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…ic#204226) ## Summary Closes elastic#166810 - Adds wildcards support for the tranform health alerting rule. - Populates transforms with alerting rules based on wildcard expressions. - Excludes `alerting_rules` from the JSON tab. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…ic#204226) ## Summary Closes elastic#166810 - Adds wildcards support for the tranform health alerting rule. - Populates transforms with alerting rules based on wildcard expressions. - Excludes `alerting_rules` from the JSON tab. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #166810
alerting_rulesfrom the JSON tab.Checklist