Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] [Vega] Implement context filter modification (#17586) #20381

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Jul 2, 2018

Backports the following commits to 6.x:

* [Vega] Implement context filter modification

elastic#17210

Testing code (click button)

```
{
  "$schema": "https://vega.github.io/schema/vega/v3.json",
  "marks": [
    {
      "name": "myButton",
      "type": "rect",
      "encode": {
        "enter": {
          "xc": {"signal": "width/2"},
          "yc": {"signal": "height/2"},
          "width": {"signal": "width*0.8"},
          "height": {"signal": "height*0.8"},

          "cornerRadius": {"value": 6},
          "strokeWidth": {"value": 10}
        },
        "update": {
          "stroke": {"value": "gray"},
          "fill": {"value": "lightgray"}
        },
        "hover": {"fill": {"value": "gray"}}
      }
    }
  ],
  "signals": [
    {
      "name": "%ADD_FILTER%",
      "on": [
        {
          "events": "@mybutton:click",
          "update": "{field: 'SRC', value: 10, operator: 'IS'}"
        }
      ]
    }
  ]
}
```
@nyurik nyurik added the backport label Jul 2, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@nyurik
Copy link
Contributor Author

nyurik commented Jul 2, 2018

jenkins test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nyurik nyurik merged commit 9ec476b into elastic:6.x Jul 2, 2018
@nyurik nyurik deleted the backport/6.x/pr-17586 branch July 2, 2018 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants