fix: [Search:WorkplaceSearch:API keys page]API key page modal dialog, flyout missing title from announcement #202716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flyout missing title from announcement Closes: elastic#201570
alexwizp
added
release_note:skip
|
/ci |
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2024
… flyout missing title from announcement (elastic#202716) Closes: elastic#201570 **Description** Dialog modal, flyout visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. **Preconditions** Stateful Workplace Search -> API keys page is opened. Use Screen Reader (NVDA). **Steps to reproduce** 1.Using only keyboard navigate to Create key button by pressing Tab key. 2.Press Enter. 3.Observe screen reader. 4.Close the flyout. 5.Navigate to Delete button. 6.Press Enter. 7.Observe screen reader. ## Changes made: 1. aria-labelledby={modalTitleId} attribute was added for mentioned EuiModal ## Screen: <img width="988" alt="image" src="https://github.com/user-attachments/assets/a1dc3586-a725-410c-be39-645bee637b88"> <img width="1194" alt="image" src="https://github.com/user-attachments/assets/aa4fba8e-4683-4bee-a5bc-8d4d2e9bd63c"> (cherry picked from commit 791aff0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 11, 2024
…ialog, flyout missing title from announcement (#202716) (#203848) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Search:WorkplaceSearch:API keys page]API key page modal dialog, flyout missing title from announcement (#202716)](#202716) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-11T16:52:17Z","message":"fix: [Search:WorkplaceSearch:API keys page]API key page modal dialog, flyout missing title from announcement (#202716)\n\nCloses: #201570\r\n\r\n**Description**\r\nDialog modal, flyout visible title should be announced for the users,\r\nespecially using assistive technology to know what dialog modal, flyout\r\nopened.\r\n\r\n**Preconditions**\r\nStateful Workplace Search -> API keys page is opened.\r\nUse Screen Reader (NVDA).\r\n\r\n**Steps to reproduce**\r\n\r\n1.Using only keyboard navigate to Create key button by pressing Tab key.\r\n2.Press Enter.\r\n3.Observe screen reader.\r\n4.Close the flyout.\r\n5.Navigate to Delete button.\r\n6.Press Enter.\r\n7.Observe screen reader.\r\n\r\n## Changes made:\r\n\r\n1. aria-labelledby={modalTitleId} attribute was added for mentioned\r\nEuiModal\r\n\r\n## Screen:\r\n\r\n<img width=\"988\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a1dc3586-a725-410c-be39-645bee637b88\">\r\n\r\n<img width=\"1194\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/aa4fba8e-4683-4bee-a5bc-8d4d2e9bd63c\">","sha":"791aff08e454f87199572e03b884eefd6cd0b116","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix: [Search:WorkplaceSearch:API keys page]API key page modal dialog, flyout missing title from announcement","number":202716,"url":"https://github.com/elastic/kibana/pull/202716","mergeCommit":{"message":"fix: [Search:WorkplaceSearch:API keys page]API key page modal dialog, flyout missing title from announcement (#202716)\n\nCloses: #201570\r\n\r\n**Description**\r\nDialog modal, flyout visible title should be announced for the users,\r\nespecially using assistive technology to know what dialog modal, flyout\r\nopened.\r\n\r\n**Preconditions**\r\nStateful Workplace Search -> API keys page is opened.\r\nUse Screen Reader (NVDA).\r\n\r\n**Steps to reproduce**\r\n\r\n1.Using only keyboard navigate to Create key button by pressing Tab key.\r\n2.Press Enter.\r\n3.Observe screen reader.\r\n4.Close the flyout.\r\n5.Navigate to Delete button.\r\n6.Press Enter.\r\n7.Observe screen reader.\r\n\r\n## Changes made:\r\n\r\n1. aria-labelledby={modalTitleId} attribute was added for mentioned\r\nEuiModal\r\n\r\n## Screen:\r\n\r\n<img width=\"988\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a1dc3586-a725-410c-be39-645bee637b88\">\r\n\r\n<img width=\"1194\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/aa4fba8e-4683-4bee-a5bc-8d4d2e9bd63c\">","sha":"791aff08e454f87199572e03b884eefd6cd0b116"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202716","number":202716,"mergeCommit":{"message":"fix: [Search:WorkplaceSearch:API keys page]API key page modal dialog, flyout missing title from announcement (#202716)\n\nCloses: #201570\r\n\r\n**Description**\r\nDialog modal, flyout visible title should be announced for the users,\r\nespecially using assistive technology to know what dialog modal, flyout\r\nopened.\r\n\r\n**Preconditions**\r\nStateful Workplace Search -> API keys page is opened.\r\nUse Screen Reader (NVDA).\r\n\r\n**Steps to reproduce**\r\n\r\n1.Using only keyboard navigate to Create key button by pressing Tab key.\r\n2.Press Enter.\r\n3.Observe screen reader.\r\n4.Close the flyout.\r\n5.Navigate to Delete button.\r\n6.Press Enter.\r\n7.Observe screen reader.\r\n\r\n## Changes made:\r\n\r\n1. aria-labelledby={modalTitleId} attribute was added for mentioned\r\nEuiModal\r\n\r\n## Screen:\r\n\r\n<img width=\"988\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a1dc3586-a725-410c-be39-645bee637b88\">\r\n\r\n<img width=\"1194\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/aa4fba8e-4683-4bee-a5bc-8d4d2e9bd63c\">","sha":"791aff08e454f87199572e03b884eefd6cd0b116"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
… flyout missing title from announcement (elastic#202716) Closes: elastic#201570 **Description** Dialog modal, flyout visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. **Preconditions** Stateful Workplace Search -> API keys page is opened. Use Screen Reader (NVDA). **Steps to reproduce** 1.Using only keyboard navigate to Create key button by pressing Tab key. 2.Press Enter. 3.Observe screen reader. 4.Close the flyout. 5.Navigate to Delete button. 6.Press Enter. 7.Observe screen reader. ## Changes made: 1. aria-labelledby={modalTitleId} attribute was added for mentioned EuiModal ## Screen: <img width="988" alt="image" src="https://github.com/user-attachments/assets/a1dc3586-a725-410c-be39-645bee637b88"> <img width="1194" alt="image" src="https://github.com/user-attachments/assets/aa4fba8e-4683-4bee-a5bc-8d4d2e9bd63c">
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
… flyout missing title from announcement (elastic#202716) Closes: elastic#201570 **Description** Dialog modal, flyout visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. **Preconditions** Stateful Workplace Search -> API keys page is opened. Use Screen Reader (NVDA). **Steps to reproduce** 1.Using only keyboard navigate to Create key button by pressing Tab key. 2.Press Enter. 3.Observe screen reader. 4.Close the flyout. 5.Navigate to Delete button. 6.Press Enter. 7.Observe screen reader. ## Changes made: 1. aria-labelledby={modalTitleId} attribute was added for mentioned EuiModal ## Screen: <img width="988" alt="image" src="https://github.com/user-attachments/assets/a1dc3586-a725-410c-be39-645bee637b88"> <img width="1194" alt="image" src="https://github.com/user-attachments/assets/aa4fba8e-4683-4bee-a5bc-8d4d2e9bd63c">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #201570
Description
Dialog modal, flyout visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened.
Preconditions
Stateful Workplace Search -> API keys page is opened.
Use Screen Reader (NVDA).
Steps to reproduce
1.Using only keyboard navigate to Create key button by pressing Tab key.
2.Press Enter.
3.Observe screen reader.
4.Close the flyout.
5.Navigate to Delete button.
6.Press Enter.
7.Observe screen reader.
Changes made:
Screen: