[React@18] Improve console.error suppression in react-testing-library setup (#201142) #202600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapral18
added
backport:prev-minor
delanni
approved these changes
Dec 6, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
cc @kapral18 |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 16, 2024
… setup (elastic#201142) (elastic#202600) In addition to changes introduced by elastic#201142 Reasoning: This pull request includes changes to the `packages/kbn-test/src/jest/setup/react_testing_library.js` file to improve internal error logging suppression from react-testing-library. In particular, [this](https://github.com/testing-library/react-hooks-testing-library/blob/1e01273374af4e48a0feb1f2233bf6c76d742167/src/core/console.ts#L1-L4) suppression logic has been migrated to avoid breaking devUX expectations. Tested against elastic#201142 code changes (cherry picked from commit 3a6d27a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 16, 2024
…ibrary setup (#201142) (#202600) (#204398) # Backport This will backport the following commits from `main` to `8.x`: - [[React@18] Improve console.error suppression in react-testing-library setup (#201142) (#202600)](#202600) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"karen.grigoryan@elastic.co"},"sourceCommit":{"committedDate":"2024-12-16T13:41:10Z","message":"[React@18] Improve console.error suppression in react-testing-library setup (#201142) (#202600)\n\nIn addition to changes introduced by #201142\r\n\r\nReasoning:\r\n\r\nThis pull request includes changes to the\r\n`packages/kbn-test/src/jest/setup/react_testing_library.js` file to\r\nimprove internal error logging suppression from react-testing-library.\r\nIn particular,\r\n[this](https://github.com/testing-library/react-hooks-testing-library/blob/1e01273374af4e48a0feb1f2233bf6c76d742167/src/core/console.ts#L1-L4)\r\nsuppression logic has been migrated to avoid breaking devUX\r\nexpectations.\r\n\r\nTested against #201142 code\r\nchanges","sha":"3a6d27af37c8ac2cdf730d206bd941554e729b9b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","React@18"],"title":"[React@18] Improve console.error suppression in react-testing-library setup (#201142)","number":202600,"url":"https://github.com/elastic/kibana/pull/202600","mergeCommit":{"message":"[React@18] Improve console.error suppression in react-testing-library setup (#201142) (#202600)\n\nIn addition to changes introduced by #201142\r\n\r\nReasoning:\r\n\r\nThis pull request includes changes to the\r\n`packages/kbn-test/src/jest/setup/react_testing_library.js` file to\r\nimprove internal error logging suppression from react-testing-library.\r\nIn particular,\r\n[this](https://github.com/testing-library/react-hooks-testing-library/blob/1e01273374af4e48a0feb1f2233bf6c76d742167/src/core/console.ts#L1-L4)\r\nsuppression logic has been migrated to avoid breaking devUX\r\nexpectations.\r\n\r\nTested against #201142 code\r\nchanges","sha":"3a6d27af37c8ac2cdf730d206bd941554e729b9b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202600","number":202600,"mergeCommit":{"message":"[React@18] Improve console.error suppression in react-testing-library setup (#201142) (#202600)\n\nIn addition to changes introduced by #201142\r\n\r\nReasoning:\r\n\r\nThis pull request includes changes to the\r\n`packages/kbn-test/src/jest/setup/react_testing_library.js` file to\r\nimprove internal error logging suppression from react-testing-library.\r\nIn particular,\r\n[this](https://github.com/testing-library/react-hooks-testing-library/blob/1e01273374af4e48a0feb1f2233bf6c76d742167/src/core/console.ts#L1-L4)\r\nsuppression logic has been migrated to avoid breaking devUX\r\nexpectations.\r\n\r\nTested against #201142 code\r\nchanges","sha":"3a6d27af37c8ac2cdf730d206bd941554e729b9b"}}]}] BACKPORT--> Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
… setup (elastic#201142) (elastic#202600) In addition to changes introduced by elastic#201142 Reasoning: This pull request includes changes to the `packages/kbn-test/src/jest/setup/react_testing_library.js` file to improve internal error logging suppression from react-testing-library. In particular, [this](https://github.com/testing-library/react-hooks-testing-library/blob/1e01273374af4e48a0feb1f2233bf6c76d742167/src/core/console.ts#L1-L4) suppression logic has been migrated to avoid breaking devUX expectations. Tested against elastic#201142 code changes
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
… setup (elastic#201142) (elastic#202600) In addition to changes introduced by elastic#201142 Reasoning: This pull request includes changes to the `packages/kbn-test/src/jest/setup/react_testing_library.js` file to improve internal error logging suppression from react-testing-library. In particular, [this](https://github.com/testing-library/react-hooks-testing-library/blob/1e01273374af4e48a0feb1f2233bf6c76d742167/src/core/console.ts#L1-L4) suppression logic has been migrated to avoid breaking devUX expectations. Tested against elastic#201142 code changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to changes introduced by #201142
Reasoning:
This pull request includes changes to the
packages/kbn-test/src/jest/setup/react_testing_library.jsfile toimprove internal error logging suppression from react-testing-library. In particular, this suppression logic has been migrated to avoid breaking devUX expectations.
Tested against #201142 code changes