-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] update playwright version + ownership #202535
Merged
dmlemeshko
merged 10 commits into
elastic:main
from
dmlemeshko:chore/playwright-ownership-change
Dec 3, 2024
Merged
[chore] update playwright version + ownership #202535
dmlemeshko
merged 10 commits into
elastic:main
from
dmlemeshko:chore/playwright-ownership-change
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shko/kibana into chore/playwright-ownership-change
dmlemeshko
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
v9.0.0
test:scout
labels
Dec 2, 2024
💚 Build Succeeded
Metrics [docs]
History
cc @dmlemeshko |
pheyos
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MadameSheema
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Dec 5, 2024
## Summary Since the new Kibana test framework has a strong dependency on `@playwright/test`, moving it under appex-qa ownership I had to update and explicitly specify types when extending the pre-existing fixtures as there was a bug fix enforcing it microsoft/playwright#32066
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
## Summary Since the new Kibana test framework has a strong dependency on `@playwright/test`, moving it under appex-qa ownership I had to update and explicitly specify types when extending the pre-existing fixtures as there was a bug fix enforcing it microsoft/playwright#32066
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Since the new Kibana test framework has a strong dependency on `@playwright/test`, moving it under appex-qa ownership I had to update and explicitly specify types when extending the pre-existing fixtures as there was a bug fix enforcing it microsoft/playwright#32066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
test:scout
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the new Kibana test framework has a strong dependency on
@playwright/test
, moving it under appex-qa ownershipI had to update and explicitly specify types when extending the pre-existing fixtures as there was a bug fix enforcing it microsoft/playwright#32066