Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update playwright version + ownership #202535

Merged
merged 10 commits into from
Dec 3, 2024

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Dec 2, 2024

Summary

Since the new Kibana test framework has a strong dependency on @playwright/test, moving it under appex-qa ownership

I had to update and explicitly specify types when extending the pre-existing fixtures as there was a bug fix enforcing it microsoft/playwright#32066

@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 test:scout labels Dec 2, 2024
@dmlemeshko dmlemeshko self-assigned this Dec 2, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @dmlemeshko

@dmlemeshko dmlemeshko marked this pull request as ready for review December 3, 2024 07:42
@dmlemeshko dmlemeshko requested a review from a team as a code owner December 3, 2024 07:42
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko merged commit 27f650b into elastic:main Dec 3, 2024
17 checks passed
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
## Summary

Since the new Kibana test framework has a strong dependency on
`@playwright/test`, moving it under appex-qa ownership

I had to update and explicitly specify types when extending the
pre-existing fixtures as there was a bug fix enforcing it
microsoft/playwright#32066
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
## Summary

Since the new Kibana test framework has a strong dependency on
`@playwright/test`, moving it under appex-qa ownership

I had to update and explicitly specify types when extending the
pre-existing fixtures as there was a bug fix enforcing it
microsoft/playwright#32066
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Since the new Kibana test framework has a strong dependency on
`@playwright/test`, moving it under appex-qa ownership

I had to update and explicitly specify types when extending the
pre-existing fixtures as there was a bug fix enforcing it
microsoft/playwright#32066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes test:scout v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants