[Cloud Security] add sideEffects: false to shared csp packages #197486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcold
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
|
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
opauloh
approved these changes
Oct 24, 2024
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
…ic#197486) ## Summary add `sideEffects: false` to shared packages for better tree shaking, see [docs](https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free) and [related discussion](https://elastic.slack.com/archives/C5TQ33ND8/p1724317421954709?thread_ts=1724314732.061379&cid=C5TQ33ND8) (cherry picked from commit 12ad715)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
…ic#197486) ## Summary add `sideEffects: false` to shared packages for better tree shaking, see [docs](https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free) and [related discussion](https://elastic.slack.com/archives/C5TQ33ND8/p1724317421954709?thread_ts=1724314732.061379&cid=C5TQ33ND8) (cherry picked from commit 12ad715)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…#197486) (#197766) # Backport This will backport the following commits from `main` to `8.16`: - [[Cloud Security] add sideEffects: false to shared csp packages (#197486)](#197486) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Kholod","email":"maxim.kholod@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T07:36:21Z","message":"[Cloud Security] add sideEffects: false to shared csp packages (#197486)\n\n## Summary\r\n\r\nadd `sideEffects: false` to shared packages for better tree shaking, see\r\n[docs](https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free)\r\nand [related\r\ndiscussion](https://elastic.slack.com/archives/C5TQ33ND8/p1724317421954709?thread_ts=1724314732.061379&cid=C5TQ33ND8)","sha":"12ad7153535238dc4a68de4cbb98e27305efc956","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","v8.16.0","v8.17.0"],"title":"[Cloud Security] add sideEffects: false to shared csp packages","number":197486,"url":"https://github.com/elastic/kibana/pull/197486","mergeCommit":{"message":"[Cloud Security] add sideEffects: false to shared csp packages (#197486)\n\n## Summary\r\n\r\nadd `sideEffects: false` to shared packages for better tree shaking, see\r\n[docs](https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free)\r\nand [related\r\ndiscussion](https://elastic.slack.com/archives/C5TQ33ND8/p1724317421954709?thread_ts=1724314732.061379&cid=C5TQ33ND8)","sha":"12ad7153535238dc4a68de4cbb98e27305efc956"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197486","number":197486,"mergeCommit":{"message":"[Cloud Security] add sideEffects: false to shared csp packages (#197486)\n\n## Summary\r\n\r\nadd `sideEffects: false` to shared packages for better tree shaking, see\r\n[docs](https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free)\r\nand [related\r\ndiscussion](https://elastic.slack.com/archives/C5TQ33ND8/p1724317421954709?thread_ts=1724314732.061379&cid=C5TQ33ND8)","sha":"12ad7153535238dc4a68de4cbb98e27305efc956"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Kholod <maxim.kholod@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…197486) (#197767) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] add sideEffects: false to shared csp packages (#197486)](#197486) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Kholod","email":"maxim.kholod@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T07:36:21Z","message":"[Cloud Security] add sideEffects: false to shared csp packages (#197486)\n\n## Summary\r\n\r\nadd `sideEffects: false` to shared packages for better tree shaking, see\r\n[docs](https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free)\r\nand [related\r\ndiscussion](https://elastic.slack.com/archives/C5TQ33ND8/p1724317421954709?thread_ts=1724314732.061379&cid=C5TQ33ND8)","sha":"12ad7153535238dc4a68de4cbb98e27305efc956","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","v8.16.0","v8.17.0"],"title":"[Cloud Security] add sideEffects: false to shared csp packages","number":197486,"url":"https://github.com/elastic/kibana/pull/197486","mergeCommit":{"message":"[Cloud Security] add sideEffects: false to shared csp packages (#197486)\n\n## Summary\r\n\r\nadd `sideEffects: false` to shared packages for better tree shaking, see\r\n[docs](https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free)\r\nand [related\r\ndiscussion](https://elastic.slack.com/archives/C5TQ33ND8/p1724317421954709?thread_ts=1724314732.061379&cid=C5TQ33ND8)","sha":"12ad7153535238dc4a68de4cbb98e27305efc956"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197486","number":197486,"mergeCommit":{"message":"[Cloud Security] add sideEffects: false to shared csp packages (#197486)\n\n## Summary\r\n\r\nadd `sideEffects: false` to shared packages for better tree shaking, see\r\n[docs](https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free)\r\nand [related\r\ndiscussion](https://elastic.slack.com/archives/C5TQ33ND8/p1724317421954709?thread_ts=1724314732.061379&cid=C5TQ33ND8)","sha":"12ad7153535238dc4a68de4cbb98e27305efc956"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Kholod <maxim.kholod@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add
sideEffects: falseto shared packages for better tree shaking, see docs and related discussion