Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Removes obselete Timeline Tour - New Features #197385

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

logeekal
Copy link
Contributor

@logeekal logeekal commented Oct 23, 2024

Summary

Handles #197295

This PR removes the obselete timeline tour which was introduced in 8.12 and may not be relevant now in 8.16.

From the perspective of users directly to 8.16 from 8.11. I guess it might be okay for users to expect considerable changes that may have happened between 8.11 and 8.16 and a tour might not be necessary 🤷

@logeekal logeekal added backport release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.0 labels Oct 23, 2024
@logeekal logeekal requested review from a team as code owners October 23, 2024 09:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2024

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / FileAttachmentEvent renders clickable name

History

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6039 6036 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB -31.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 87.6KB 87.6KB -59.0B

History

@logeekal logeekal enabled auto-merge (squash) October 25, 2024 03:02
@logeekal logeekal merged commit 663a339 into elastic:main Oct 25, 2024
45 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11511992873

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2024
…astic#197385)

## Summary

Handles elastic#197295

This PR removes the obselete timeline tour which was introduced in
`8.12` and may not be relevant now in `8.16`.

From the perspective of users directly to `8.16` from `8.11`. I guess it
might be okay for users to expect considerable changes that may have
happened between `8.11` and `8.16` and a tour might not be necessary 🤷

(cherry picked from commit 663a339)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2024
…astic#197385)

## Summary

Handles elastic#197295

This PR removes the obselete timeline tour which was introduced in
`8.12` and may not be relevant now in `8.16`.

From the perspective of users directly to `8.16` from `8.11`. I guess it
might be okay for users to expect considerable changes that may have
happened between `8.11` and `8.16` and a tour might not be necessary 🤷

(cherry picked from commit 663a339)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 25, 2024
…res (#197385) (#197754)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution] Removes obselete Timeline Tour - New Features
(#197385)](#197385)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T04:41:35Z","message":"[Security
Solution] Removes obselete Timeline Tour - New Features (#197385)\n\n##
Summary\r\n\r\nHandles
https://github.com/elastic/kibana/issues/197295\r\n\r\nThis PR removes
the obselete timeline tour which was introduced in\r\n`8.12` and may not
be relevant now in `8.16`.\r\n\r\nFrom the perspective of users directly
to `8.16` from `8.11`. I guess it\r\nmight be okay for users to expect
considerable changes that may have\r\nhappened between `8.11` and `8.16`
and a tour might not be necessary
🤷","sha":"663a339b3a4937682346d5e762da212c4d4e109a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Fleet","v9.0.0","Team:Threat
Hunting:Investigations","v8.16.0"],"title":"[Security Solution] Removes
obselete Timeline Tour - New
Features","number":197385,"url":"https://github.com/elastic/kibana/pull/197385","mergeCommit":{"message":"[Security
Solution] Removes obselete Timeline Tour - New Features (#197385)\n\n##
Summary\r\n\r\nHandles
https://github.com/elastic/kibana/issues/197295\r\n\r\nThis PR removes
the obselete timeline tour which was introduced in\r\n`8.12` and may not
be relevant now in `8.16`.\r\n\r\nFrom the perspective of users directly
to `8.16` from `8.11`. I guess it\r\nmight be okay for users to expect
considerable changes that may have\r\nhappened between `8.11` and `8.16`
and a tour might not be necessary
🤷","sha":"663a339b3a4937682346d5e762da212c4d4e109a"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197385","number":197385,"mergeCommit":{"message":"[Security
Solution] Removes obselete Timeline Tour - New Features (#197385)\n\n##
Summary\r\n\r\nHandles
https://github.com/elastic/kibana/issues/197295\r\n\r\nThis PR removes
the obselete timeline tour which was introduced in\r\n`8.12` and may not
be relevant now in `8.16`.\r\n\r\nFrom the perspective of users directly
to `8.16` from `8.11`. I guess it\r\nmight be okay for users to expect
considerable changes that may have\r\nhappened between `8.11` and `8.16`
and a tour might not be necessary
🤷","sha":"663a339b3a4937682346d5e762da212c4d4e109a"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 25, 2024
…es (#197385) (#197755)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Removes obselete Timeline Tour - New Features
(#197385)](#197385)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T04:41:35Z","message":"[Security
Solution] Removes obselete Timeline Tour - New Features (#197385)\n\n##
Summary\r\n\r\nHandles
https://github.com/elastic/kibana/issues/197295\r\n\r\nThis PR removes
the obselete timeline tour which was introduced in\r\n`8.12` and may not
be relevant now in `8.16`.\r\n\r\nFrom the perspective of users directly
to `8.16` from `8.11`. I guess it\r\nmight be okay for users to expect
considerable changes that may have\r\nhappened between `8.11` and `8.16`
and a tour might not be necessary
🤷","sha":"663a339b3a4937682346d5e762da212c4d4e109a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Fleet","v9.0.0","Team:Threat
Hunting:Investigations","v8.16.0"],"title":"[Security Solution] Removes
obselete Timeline Tour - New
Features","number":197385,"url":"https://github.com/elastic/kibana/pull/197385","mergeCommit":{"message":"[Security
Solution] Removes obselete Timeline Tour - New Features (#197385)\n\n##
Summary\r\n\r\nHandles
https://github.com/elastic/kibana/issues/197295\r\n\r\nThis PR removes
the obselete timeline tour which was introduced in\r\n`8.12` and may not
be relevant now in `8.16`.\r\n\r\nFrom the perspective of users directly
to `8.16` from `8.11`. I guess it\r\nmight be okay for users to expect
considerable changes that may have\r\nhappened between `8.11` and `8.16`
and a tour might not be necessary
🤷","sha":"663a339b3a4937682346d5e762da212c4d4e109a"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197385","number":197385,"mergeCommit":{"message":"[Security
Solution] Removes obselete Timeline Tour - New Features (#197385)\n\n##
Summary\r\n\r\nHandles
https://github.com/elastic/kibana/issues/197295\r\n\r\nThis PR removes
the obselete timeline tour which was introduced in\r\n`8.12` and may not
be relevant now in `8.16`.\r\n\r\nFrom the perspective of users directly
to `8.16` from `8.11`. I guess it\r\nmight be okay for users to expect
considerable changes that may have\r\nhappened between `8.11` and `8.16`
and a tour might not be necessary
🤷","sha":"663a339b3a4937682346d5e762da212c4d4e109a"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants