Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLOs] Refactor add slo route context #194633

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[SLOs] Refactor add slo route context #194633

wants to merge 2 commits into from
+801 −905

Conversation

shahzad31
Copy link
Contributor

Summary

Refactor add slo route context !!

i had done this as part of #186974

i thought it might be nice to bring it in !!

@shahzad31 shahzad31 requested a review from a team as a code owner October 1, 2024 19:02
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Oct 1, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 1, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 1, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / Policy Advanced Settings section should expand and collapse section when button is clicked
  • [job] [logs] Jest Tests #8 / Policy Advanced Settings section should expand and collapse section when button is clicked
  • [job] [logs] Jest Tests #5 / Summary Search Client handles hideStale filter
  • [job] [logs] Jest Tests #5 / Summary Search Client handles hideStale filter
  • [job] [logs] Jest Tests #5 / Summary Search Client handles summaryUpdate kql filter override
  • [job] [logs] Jest Tests #5 / Summary Search Client handles summaryUpdate kql filter override

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 marked this pull request as draft October 17, 2024 13:48
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @elasticmachine @kibana-ci @kibanamachine