Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search] Disable bfetch by default #192789

Merged
merged 11 commits into from
Oct 10, 2024

Conversation

lukasolson
Copy link
Member

Summary

Part of #186139.

Disables bfetch by default.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) labels Sep 12, 2024
@lukasolson lukasolson self-assigned this Sep 12, 2024
@lukasolson
Copy link
Member Author

/ci

@lukasolson lukasolson marked this pull request as ready for review September 27, 2024 15:57
@lukasolson lukasolson requested a review from a team as a code owner September 27, 2024 15:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Sep 27, 2024
@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 2, 2024
@ppisljar
Copy link
Member

ppisljar commented Oct 5, 2024

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 5, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #50 / EPM Endpoints installs packages that include settings and mappings overrides should install the overrides package correctly
  • [job] [logs] FTR Configs #50 / EPM Endpoints installs packages that include settings and mappings overrides should install the overrides package correctly
  • [job] [logs] FTR Configs #59 / Maps endpoints apis bsearch ES|QL should return getValues response in expected shape
  • [job] [logs] FTR Configs #59 / Maps endpoints apis bsearch ES|QL should return getValues response in expected shape

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @lukasolson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants