[Chore] Remove third-party testing internals from test snapshots #192747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some indavertent testing of third-party APIs/implementations by not directly passing the result of a `render()` call to `toMatchSnapshot()`. In all cases, this was solved by passing `render().container` (the root element rendered by the testing library) instead. These changes remove implementation details of both styled-components (elastic#192368 being the reason for this commit) and testing-library from the snapshots.
rylnd
added
release_note:skip
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
nkhristinin
approved these changes
Sep 13, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v9.0.0
backport:skip
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Sep 18, 2024
…stic#192747) ## Summary This removes some indavertent testing of third-party APIs/implementations caused by directly passing the result of a `render()` call to `toMatchSnapshot()`. In all cases, this was solved by passing `render().container` (the root element rendered by the testing library) instead. These changes remove implementation details of both styled-components (elastic#192368 being the reason for this commit) and testing-library from the snapshots. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes some indavertent testing of third-party APIs/implementations caused by directly passing the result of a
render()call totoMatchSnapshot().In all cases, this was solved by passing
render().container(the root element rendered by the testing library) instead.These changes remove implementation details of both styled-components (#192368 being the reason for this commit) and testing-library from the snapshots.
Checklist