Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tableVis] additional view options #1926

Merged
merged 15 commits into from
Nov 17, 2014

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 13, 2014

fixes #1911

Adds two (and a half) options to the TableVis, along with many tests (which previously were only for supporting modules).

1. Show metrics for every bucket/level

default: false
Checking this option makes the vis behave like the pie, and calculate the given metrics for each bucketting level.
image

2. Show partial rows

default: false
Allow rows that are incomplete to be shown. This causes the metrics to be calculated at every level because knowing what buckets exist without knowing anything about the contents seems pretty useless. This way, when a row is incomplete, we can show data from the last bucket we were able to create.
image

½. Calculate metrics for every bucket/level

default: false
This option can't actually be controlled by the user, but I'm including it in the panel to show the implications of activating something like "Show partial rows"

all together now

image

@spalger spalger changed the title [tableVis] allow displaying partial rows [tableVis] additional view options Nov 14, 2014
@spalger spalger added the review label Nov 14, 2014
@jimmyjones2
Copy link
Contributor

Looks great! Is it useful to show the metrics for each bucket, or could the last column just show the last non-empty bucket metric? So in the "all together now" screenshot you'd lose the 2nd column, but the final "count of documents" would contain 1 for all the records. "Show partial rows" would then imply "Calculate metrics for each bucket", so only one option would be required. Just my 2 cents though, thinking of my use cases.

@spalger
Copy link
Contributor Author

spalger commented Nov 15, 2014

Hmm, good point. I'm concerned about the performance implications of running the metric for every bucket without the user opting-in, but I can imagine that it's the only way that partial rows would really be useful. I'll get some feedback from @rashidkpc and the gang on monday and see what they think. Thanks for helping make Kibana better! 😄

@jimmyjones2
Copy link
Contributor

Awesome!

@simianhacker
Copy link
Member

Merge from Master and LGTM!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to show results for empty buckets
3 participants