Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixes link to anomaly detection wizard from pattern analysis in Discover #192375

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Sep 9, 2024

Fixes issue when clicking the Create job using wizard link in Discover. Some queries cause problems with the various searches the wizard performs.

image

This was caused by the query being added to the URL as a string when it needs to be an object so it is correctly converted to the rison format.

@jgowdyelastic jgowdyelastic marked this pull request as ready for review September 9, 2024 14:07
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner September 9, 2024 14:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@peteharverson peteharverson changed the title [ML] Fixing link to AD wizard from pattern analysis in Discover [ML] Fixes link to anomaly detection wizard from pattern analysis in Discover Sep 10, 2024
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed I no longer see the validation errors on switching to the categorization job wizard that I saw before.

@jgowdyelastic jgowdyelastic enabled auto-merge (squash) September 10, 2024 09:10
@jgowdyelastic jgowdyelastic merged commit 4d28bd6 into elastic:main Sep 10, 2024
20 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.6MB 4.6MB -16.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 10, 2024
…Discover (elastic#192375)

Fixes issue when clicking the `Create job using wizard` link in
Discover. Some queries cause problems with the various searches the
wizard performs.

![image](https://github.com/user-attachments/assets/79dc5920-d57d-422d-909a-61d66f3dcbe0)

This was caused by the query being added to the URL as a string when it
needs to be an object so it is correctly converted to the rison format.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 4d28bd6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@jgowdyelastic jgowdyelastic deleted the fixing-link-to-ad-wizard-from-discover branch September 10, 2024 10:58
kibanamachine added a commit that referenced this pull request Sep 10, 2024
…sis in Discover (#192375) (#192452)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ML] Fixes link to anomaly detection wizard from pattern analysis in
Discover (#192375)](#192375)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2024-09-10T10:05:21Z","message":"[ML]
Fixes link to anomaly detection wizard from pattern analysis in Discover
(#192375)\n\nFixes issue when clicking the `Create job using wizard`
link in\r\nDiscover. Some queries cause problems with the various
searches the\r\nwizard
performs.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/79dc5920-d57d-422d-909a-61d66f3dcbe0)\r\n\r\nThis
was caused by the query being added to the URL as a string when
it\r\nneeds to be an object so it is correctly converted to the rison
format.\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"4d28bd62031f57785a89103c6c46550031a38303","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly
Detection","v8.16.0","v8.15.2"],"title":"[ML] Fixes link to anomaly
detection wizard from pattern analysis in
Discover","number":192375,"url":"https://github.com/elastic/kibana/pull/192375","mergeCommit":{"message":"[ML]
Fixes link to anomaly detection wizard from pattern analysis in Discover
(#192375)\n\nFixes issue when clicking the `Create job using wizard`
link in\r\nDiscover. Some queries cause problems with the various
searches the\r\nwizard
performs.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/79dc5920-d57d-422d-909a-61d66f3dcbe0)\r\n\r\nThis
was caused by the query being added to the URL as a string when
it\r\nneeds to be an object so it is correctly converted to the rison
format.\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"4d28bd62031f57785a89103c6c46550031a38303"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192375","number":192375,"mergeCommit":{"message":"[ML]
Fixes link to anomaly detection wizard from pattern analysis in Discover
(#192375)\n\nFixes issue when clicking the `Create job using wizard`
link in\r\nDiscover. Some queries cause problems with the various
searches the\r\nwizard
performs.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/79dc5920-d57d-422d-909a-61d66f3dcbe0)\r\n\r\nThis
was caused by the query being added to the URL as a string when
it\r\nneeds to be an object so it is correctly converted to the rison
format.\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"4d28bd62031f57785a89103c6c46550031a38303"}},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <jgowdy@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants