Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Cases] Design Review changes #1 #192356

Merged
merged 6 commits into from
Sep 12, 2024
Merged

[ResponseOps][Cases] Design Review changes #1 #192356

merged 6 commits into from
Sep 12, 2024

Conversation

adcoelho
Copy link
Contributor

@adcoelho adcoelho commented Sep 9, 2024

Connected to #188187

Summary

  • Changed the cases Settings button and icon
  • Changed the the Additional fields title to Custom fields for consistency
Screenshot 2024-09-09 at 20 15 39 Screenshot 2024-09-09 at 20 34 27 Screenshot 2024-09-09 at 20 34 57

@adcoelho adcoelho added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.16.0 labels Sep 9, 2024
@adcoelho adcoelho self-assigned this Sep 9, 2024
@adcoelho adcoelho requested a review from a team as a code owner September 9, 2024 11:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

guskovaue
guskovaue approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@guskovaue guskovaue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

js-jankisalvi
js-jankisalvi approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified locally, works as expected 👍

x-pack/plugins/cases/public/components/links/index.test.tsx Outdated Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 491.1KB 491.3KB +148.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
cases 63 62 -1

Total ESLint disabled count

id before after diff
cases 80 79 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

@adcoelho adcoelho merged commit 6f7bc21 into elastic:main Sep 12, 2024
23 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 12, 2024
@szaffarano szaffarano mentioned this pull request Sep 13, 2024
Merged
1 task
gergoabraham pushed a commit to gergoabraham/kibana that referenced this pull request Sep 13, 2024
@adcoelho @gergoabraham
[ResponseOps][Cases] Design Review changes elastic#1 (elastic#192356)
911e81e 
Connected to elastic#188187

## Summary

- Changed the cases `Settings` button and icon
- Changed the the `Additional fields` title to `Custom fields` for
consistency

<img width="1728" alt="Screenshot 2024-09-09 at 20 15 39"
src="https://github.com/user-attachments/assets/1fb1232a-f958-4d4d-8694-f85cc8872237">
<img width="1443" alt="Screenshot 2024-09-09 at 20 34 27"
src="https://github.com/user-attachments/assets/0fbdae02-65a6-4128-adc7-39f51cc2d5e6">
<img width="1370" alt="Screenshot 2024-09-09 at 20 34 57"
src="https://github.com/user-attachments/assets/c216407a-ac13-4579-8007-531c79d52de7">
@cnasikas cnasikas mentioned this pull request Sep 10, 2024
Open
6 tasks
markov00 pushed a commit to markov00/kibana that referenced this pull request Sep 18, 2024
@adcoelho @markov00
[ResponseOps][Cases] Design Review changes elastic#1 (elastic#192356)
281c57b 
Connected to elastic#188187

## Summary

- Changed the cases `Settings` button and icon
- Changed the the `Additional fields` title to `Custom fields` for
consistency

<img width="1728" alt="Screenshot 2024-09-09 at 20 15 39"
src="https://github.com/user-attachments/assets/1fb1232a-f958-4d4d-8694-f85cc8872237">
<img width="1443" alt="Screenshot 2024-09-09 at 20 34 27"
src="https://github.com/user-attachments/assets/0fbdae02-65a6-4128-adc7-39f51cc2d5e6">
<img width="1370" alt="Screenshot 2024-09-09 at 20 34 57"
src="https://github.com/user-attachments/assets/c216407a-ac13-4579-8007-531c79d52de7">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guskovaue guskovaue guskovaue approved these changes

@js-jankisalvi js-jankisalvi js-jankisalvi approved these changes

Assignees

@adcoelho adcoelho

Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adcoelho @elasticmachine @kibana-ci @guskovaue @js-jankisalvi @kibanamachine