Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixes links to the Single Metric Viewer from the Annotations and Forecasts tables #192000

Merged
merged 4 commits into from
Sep 5, 2024
Merged

[ML] Fixes links to the Single Metric Viewer from the Annotations and Forecasts tables #192000

merged 4 commits into from
Sep 5, 2024

Conversation

rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Sep 3, 2024 •
edited
Loading

Summary

Fix for: #191936
Fixes navigation from the Forecasts & Annotations table to the Single Metric Viewer. Added functional tests.
Tested on 8.15 - issue doesn't exist, it was probably introduced in #189729

Checklist

@rbrtj rbrtj added release_note:fix :ml Feature:Anomaly Detection ML anomaly detection Team:ML Team label for ML (also use :ml) v8.16.0 labels Sep 3, 2024
@rbrtj rbrtj requested a review from a team as a code owner September 3, 2024 14:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.6MB 4.6MB +60.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ⚡

walterra
walterra approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM, great to see the tests added to cover this!

@rbrtj rbrtj merged commit c82ca8e into elastic:main Sep 5, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 5, 2024
@peteharverson peteharverson changed the title [ML] Links to the Single Metric Viewer from the Annotations and Forecasts table fix [ML] Fixes links to the Single Metric Viewer from the Annotations and Forecasts table Sep 10, 2024
@peteharverson peteharverson changed the title [ML] Fixes links to the Single Metric Viewer from the Annotations and Forecasts table [ML] Fixes links to the Single Metric Viewer from the Annotations and Forecasts tables Sep 10, 2024
@peteharverson peteharverson mentioned this pull request Sep 6, 2024
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@rbrtj rbrtj

Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:fix Team:ML Team label for ML (also use :ml) v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rbrtj @elasticmachine @kibana-ci @walterra @alvarezmelissa87 @kibanamachine