[CI] Enable failed test collection on ES-intake triggered serverless verification runs #191937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are triggered by es-serverless-intake
delanni
commented
Sep 2, 2024
| if [[ $BUILDKITE_TRIGGERED_FROM_BUILD_PIPELINE_SLUG == 'elasticsearch-serverless-intake' ]]; then | ||
| echo "--- Run Failed Test Reporter (only junit)" | ||
| node scripts/report_failed_tests --build-url="${BUILDKITE_BUILD_URL}#${BUILDKITE_JOB_ID}" 'target/junit/**/*.xml'\ | ||
| --no-github-update --no-index-errors |
There was a problem hiding this comment.
@elastic/kibana-operations - am I understanding these scripts right, that the test failure report is what's missing for me, and to prevent it from muddying our stats (probably the reason why it was skipped before) we can add these flags?
There was a problem hiding this comment.
I'd give it a test run before merging, I don't think the flags have ever been used. Sounds right though based on the documentation.
There was a problem hiding this comment.
Tested: https://buildkite.com/elastic/kibana-elasticsearch-serverless-verify-and-promote/builds/1962 - seems to be working, and does what I hoped!
However, it's interesting, that breaking one test broke 2 suites, maybe there's some overlap.
delanni
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
delanni
force-pushed
the
report-on-es-intake-triggers
branch
from
75547fe
to
515d29d
Compare
jbudz
approved these changes
Sep 4, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 4, 2024
…verification runs (elastic#191937) ## Summary Currently, failed runs on https://buildkite.com/elastic/kibana-elasticsearch-serverless-verify-and-promote that were triggered by the ES Serverless pipeline's downstream, are not collecting failures. This makes it harder to grasp what set of tests failed. I think we originally disabled this reporting not to muddy our stats based on runs on various ES Serverless versions - however, with this, it's really hard to get an overview on which tests are failing for a run, so I'd like to get the failed suites to be displayed on the job. With this change - if I'm not mistaken - we'll generate the annotation on the Buildkite job, but we won't report to ci-stats or create github issues. ### In short What we have: <img width="889" alt="Screenshot 2024-09-02 at 18 28 45" src="https://github.com/user-attachments/assets/d294dc00-4dd0-4b29-9e2f-866d68246a5d"> What I'd like: <img width="1195" alt="Screenshot 2024-09-02 at 18 29 14" src="https://github.com/user-attachments/assets/455465ba-f176-4ab5-ba31-9578c167448f"> Tested in: https://buildkite.com/elastic/kibana-elasticsearch-serverless-verify-and-promote/builds/1962 (cherry picked from commit 243de82)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 4, 2024
…erless verification runs (#191937) (#192103) # Backport This will backport the following commits from `main` to `8.15`: - [[CI] Enable failed test collection on ES-intake triggered serverless verification runs (#191937)](#191937) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2024-09-04T14:58:45Z","message":"[CI] Enable failed test collection on ES-intake triggered serverless verification runs (#191937)\n\n## Summary\r\nCurrently, failed runs on\r\nhttps://buildkite.com/elastic/kibana-elasticsearch-serverless-verify-and-promote\r\nthat were triggered by the ES Serverless pipeline's downstream, are not\r\ncollecting failures. This makes it harder to grasp what set of tests\r\nfailed.\r\n\r\nI think we originally disabled this reporting not to muddy our stats\r\nbased on runs on various ES Serverless versions - however, with this,\r\nit's really hard to get an overview on which tests are failing for a\r\nrun, so I'd like to get the failed suites to be displayed on the job.\r\n\r\nWith this change - if I'm not mistaken - we'll generate the annotation\r\non the Buildkite job, but we won't report to ci-stats or create github\r\nissues.\r\n\r\n### In short\r\nWhat we have:\r\n<img width=\"889\" alt=\"Screenshot 2024-09-02 at 18 28 45\"\r\nsrc=\"https://github.com/user-attachments/assets/d294dc00-4dd0-4b29-9e2f-866d68246a5d\">\r\n\r\nWhat I'd like:\r\n<img width=\"1195\" alt=\"Screenshot 2024-09-02 at 18 29 14\"\r\nsrc=\"https://github.com/user-attachments/assets/455465ba-f176-4ab5-ba31-9578c167448f\">\r\n\r\n\r\nTested in:\r\nhttps://buildkite.com/elastic/kibana-elasticsearch-serverless-verify-and-promote/builds/1962","sha":"243de82cc6b7bb7ac7639c65c19147509674b487","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:prev-minor","v8.16.0"],"title":"[CI] Enable failed test collection on ES-intake triggered serverless verification runs","number":191937,"url":"#191937 Enable failed test collection on ES-intake triggered serverless verification runs (#191937)\n\n## Summary\r\nCurrently, failed runs on\r\nhttps://buildkite.com/elastic/kibana-elasticsearch-serverless-verify-and-promote\r\nthat were triggered by the ES Serverless pipeline's downstream, are not\r\ncollecting failures. This makes it harder to grasp what set of tests\r\nfailed.\r\n\r\nI think we originally disabled this reporting not to muddy our stats\r\nbased on runs on various ES Serverless versions - however, with this,\r\nit's really hard to get an overview on which tests are failing for a\r\nrun, so I'd like to get the failed suites to be displayed on the job.\r\n\r\nWith this change - if I'm not mistaken - we'll generate the annotation\r\non the Buildkite job, but we won't report to ci-stats or create github\r\nissues.\r\n\r\n### In short\r\nWhat we have:\r\n<img width=\"889\" alt=\"Screenshot 2024-09-02 at 18 28 45\"\r\nsrc=\"https://github.com/user-attachments/assets/d294dc00-4dd0-4b29-9e2f-866d68246a5d\">\r\n\r\nWhat I'd like:\r\n<img width=\"1195\" alt=\"Screenshot 2024-09-02 at 18 29 14\"\r\nsrc=\"https://github.com/user-attachments/assets/455465ba-f176-4ab5-ba31-9578c167448f\">\r\n\r\n\r\nTested in:\r\nhttps://buildkite.com/elastic/kibana-elasticsearch-serverless-verify-and-promote/builds/1962","sha":"243de82cc6b7bb7ac7639c65c19147509674b487"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"#191937 Enable failed test collection on ES-intake triggered serverless verification runs (#191937)\n\n## Summary\r\nCurrently, failed runs on\r\nhttps://buildkite.com/elastic/kibana-elasticsearch-serverless-verify-and-promote\r\nthat were triggered by the ES Serverless pipeline's downstream, are not\r\ncollecting failures. This makes it harder to grasp what set of tests\r\nfailed.\r\n\r\nI think we originally disabled this reporting not to muddy our stats\r\nbased on runs on various ES Serverless versions - however, with this,\r\nit's really hard to get an overview on which tests are failing for a\r\nrun, so I'd like to get the failed suites to be displayed on the job.\r\n\r\nWith this change - if I'm not mistaken - we'll generate the annotation\r\non the Buildkite job, but we won't report to ci-stats or create github\r\nissues.\r\n\r\n### In short\r\nWhat we have:\r\n<img width=\"889\" alt=\"Screenshot 2024-09-02 at 18 28 45\"\r\nsrc=\"https://github.com/user-attachments/assets/d294dc00-4dd0-4b29-9e2f-866d68246a5d\">\r\n\r\nWhat I'd like:\r\n<img width=\"1195\" alt=\"Screenshot 2024-09-02 at 18 29 14\"\r\nsrc=\"https://github.com/user-attachments/assets/455465ba-f176-4ab5-ba31-9578c167448f\">\r\n\r\n\r\nTested in:\r\nhttps://buildkite.com/elastic/kibana-elasticsearch-serverless-verify-and-promote/builds/1962","sha":"243de82cc6b7bb7ac7639c65c19147509674b487"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, failed runs on https://buildkite.com/elastic/kibana-elasticsearch-serverless-verify-and-promote that were triggered by the ES Serverless pipeline's downstream, are not collecting failures. This makes it harder to grasp what set of tests failed.
I think we originally disabled this reporting not to muddy our stats based on runs on various ES Serverless versions - however, with this, it's really hard to get an overview on which tests are failing for a run, so I'd like to get the failed suites to be displayed on the job.
With this change - if I'm not mistaken - we'll generate the annotation on the Buildkite job, but we won't report to ci-stats or create github issues.
In short
What we have:
What I'd like:
Tested in: https://buildkite.com/elastic/kibana-elasticsearch-serverless-verify-and-promote/builds/1962