-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra][Flaky Test Fix] Failing test: Single Host Flyout Tabs Metadata Tab should render metadata tab, add and remove filter #191745
Conversation
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
HistoryTo update your PR or re-run it, just comment with: |
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6832 (passed 💚 ) |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6832[✅] x-pack/test/functional/apps/infra/config.ts: 25/25 tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jenny for fixing this 🎉
Closes #191565
Summary
This PR fixes a flaky test - I couldn't reproduce it locally (tried many times) but I saw in the build screenshot that a different field was added to the filters (
host.hostname
instead ofhost.name
) so I made the selector stricter to make sure that it will always click on the correct button (usinghost.name
)