Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra][Flaky Test Fix] Failing test: Single Host Flyout Tabs Metadata Tab should render metadata tab, add and remove filter #191745

Conversation

jennypavlova
Copy link
Member

Closes #191565

Summary

This PR fixes a flaky test - I couldn't reproduce it locally (tried many times) but I saw in the build screenshot that a different field was added to the filters (host.hostname instead of host.name) so I made the selector stricter to make sure that it will always click on the correct button (using host.name)

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Aug 29, 2024
@jennypavlova jennypavlova self-assigned this Aug 29, 2024
@jennypavlova jennypavlova requested a review from a team as a code owner August 29, 2024 15:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Aug 29, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 29, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 5ddd7af
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191745-5ddd7afffdae

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #83 / serverless observability UI Serverless Observability Cases Cases list row actions Severity to high

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.5MB 1.5MB +57.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

@jennypavlova
Copy link
Member Author

jennypavlova commented Aug 29, 2024

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6832 (passed 💚 )

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6832

[✅] x-pack/test/functional/apps/infra/config.ts: 25/25 tests passed.

see run history

Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jenny for fixing this 🎉

@jennypavlova jennypavlova merged commit fbbed11 into elastic:main Aug 30, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0
Projects
None yet
7 participants