-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Migrate expression runner from bfetch to an HTTP route #191031
Conversation
/ci |
/ci |
/ci |
Pinging @elastic/kibana-presentation (Team:Presentation) |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Any Before this PR, it uses bfetch to batch multiple calls: before.movAfter this PR, each request goes out individually: after.mov |
Thanks for clarifying. Could you provide an example element expression that uses a function? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana-presentation changes LGTM. Thanks for removing bfetch from canvas.
code review and tested in chrome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana.jsonc
changes LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @lukasolson |
Summary
Resolves #190267.
Moves the Canvas expression runner off of
bfetch
and onto the corehttp
router.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers