[Fleet] fix restart upgrade disabled condition #184586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:fix
backport:prev-minor
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 3, 2024
## Summary Closes elastic#184212 Fix the Restart upgrade modal submit button disabled condition. It was not correct for single agent restart, the restart was disabled. To verify: - enroll an agent with an older version e.g. 8.13.1 - upgrade agent with a fictive version e.g. 8.13.5 - update the agent doc to set the `upgrade_started_at` to more than 2 hours ago - go to `Restart upgrade`, the modal window show enable submit <img width="818" alt="image" src="https://github.com/elastic/kibana/assets/90178898/0edbbb1a-7a51-4287-8598-0d4437bbc874"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 1750ab8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
rohanxz
pushed a commit
to honeyn303/kibana
that referenced
this pull request
Jun 4, 2024
## Summary Closes elastic#184212 Fix the Restart upgrade modal submit button disabled condition. It was not correct for single agent restart, the restart was disabled. To verify: - enroll an agent with an older version e.g. 8.13.1 - upgrade agent with a fictive version e.g. 8.13.5 - update the agent doc to set the `upgrade_started_at` to more than 2 hours ago - go to `Restart upgrade`, the modal window show enable submit <img width="818" alt="image" src="https://github.com/elastic/kibana/assets/90178898/0edbbb1a-7a51-4287-8598-0d4437bbc874"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Jun 5, 2024
) # Backport This will backport the following commits from `main` to `8.14`: - [[Fleet] fix restart upgrade disabled condition (#184586)](#184586) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-06-03T13:53:06Z","message":"[Fleet] fix restart upgrade disabled condition (#184586)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/184212\r\n\r\nFix the Restart upgrade modal submit button disabled condition. It was\r\nnot correct for single agent restart, the restart was disabled.\r\n\r\nTo verify:\r\n- enroll an agent with an older version e.g. 8.13.1\r\n- upgrade agent with a fictive version e.g. 8.13.5\r\n- update the agent doc to set the `upgrade_started_at` to more than 2\r\nhours ago\r\n- go to `Restart upgrade`, the modal window show enable submit\r\n\r\n\r\n<img width=\"818\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/0edbbb1a-7a51-4287-8598-0d4437bbc874\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1750ab8676dadb3d6f2f3dbfe0ee9ea95de66733","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.15.0"],"title":"[Fleet] fix restart upgrade disabled condition","number":184586,"url":"https://github.com/elastic/kibana/pull/184586","mergeCommit":{"message":"[Fleet] fix restart upgrade disabled condition (#184586)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/184212\r\n\r\nFix the Restart upgrade modal submit button disabled condition. It was\r\nnot correct for single agent restart, the restart was disabled.\r\n\r\nTo verify:\r\n- enroll an agent with an older version e.g. 8.13.1\r\n- upgrade agent with a fictive version e.g. 8.13.5\r\n- update the agent doc to set the `upgrade_started_at` to more than 2\r\nhours ago\r\n- go to `Restart upgrade`, the modal window show enable submit\r\n\r\n\r\n<img width=\"818\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/0edbbb1a-7a51-4287-8598-0d4437bbc874\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1750ab8676dadb3d6f2f3dbfe0ee9ea95de66733"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/184586","number":184586,"mergeCommit":{"message":"[Fleet] fix restart upgrade disabled condition (#184586)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/184212\r\n\r\nFix the Restart upgrade modal submit button disabled condition. It was\r\nnot correct for single agent restart, the restart was disabled.\r\n\r\nTo verify:\r\n- enroll an agent with an older version e.g. 8.13.1\r\n- upgrade agent with a fictive version e.g. 8.13.5\r\n- update the agent doc to set the `upgrade_started_at` to more than 2\r\nhours ago\r\n- go to `Restart upgrade`, the modal window show enable submit\r\n\r\n\r\n<img width=\"818\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/0edbbb1a-7a51-4287-8598-0d4437bbc874\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1750ab8676dadb3d6f2f3dbfe0ee9ea95de66733"}}]}] BACKPORT--> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
kibanamachine
added
v8.14.0
and removed
backport missing
|
This PR didn't land on time for latest v8.14.0 BC. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #184212
Fix the Restart upgrade modal submit button disabled condition. It was not correct for single agent restart, the restart was disabled.
To verify:
upgrade_started_atto more than 2 hours agoRestart upgrade, the modal window show enable submitChecklist