[Security Solution][Sourcerer] Colocate sourcerer files #184149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgestc
force-pushed
the
colocate_sourcerer_files
branch
5 times, most recently
from
381de18
to
8a8b774
Compare
lgestc
force-pushed
the
colocate_sourcerer_files
branch
from
8a8b774
to
3f81092
Compare
lgestc
changed the title
lgestc
added
v8.15.0
Team:Threat Hunting:Investigations
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
kqualters-elastic
approved these changes
May 28, 2024
machadoum
approved these changes
May 29, 2024
patrykkopycinski
approved these changes
May 29, 2024
maxcold
approved these changes
May 29, 2024
xcrzx
approved these changes
May 29, 2024
stephmilovic
approved these changes
May 29, 2024
dhurley14
approved these changes
May 30, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TLDR; Even though many files are changed here, its only about sorting out the imports and file locations.
Moving sourcerer to a single directory, to keep entire feature implmentation close - in an effort to draw clear boundaries over its api, imports and exports - similar to how
security flyoutis implemented.This is a starting point towards refactoring the component to use discover picker and apis.