-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Consolidate redundant time_buckets
into @kbn/ml-time-buckets
.
#178756
Conversation
be21b4b
to
bb0264c
Compare
Pinging @elastic/ml-ui (:ml) |
|
||
import { isTimeSeriesViewJob } from '../../../../common/util/job_utils'; | ||
import { parseInterval } from '../../../../common/util/parse_interval'; | ||
|
||
import { getBoundsRoundedToInterval, getTimeBucketsFromCache } from '../../util/time_buckets'; | ||
import { getTimeBucketsFromCache } from '../../util/get_time_buckets_from_cache'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file will be removed via #178566
but good catch on creating a separate file for getTimeBucketsFromCache
for settings.ts
which still uses it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, let's get yours in first and then see if I get any conflicts with this one.
Code LGTM - will give it a test tomorrow and update. Nice piece of work! 🙏 |
Tested the following and functionally had no issues:
Code also LGTM 🎉 |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @walterra |
Summary
Follow up to #46227.
Consolidates multiple copies of
time_buckets.js
into@kbn/ml-time-buckets
. The scope of this PR is just to consolidate the files. In follow ups we still need to: Refactor JS to TS and get rid of the code that uses this using "dependency cache" in theml
plugin.Checklist